ca/dc60913e3bf2a5168e754386fa491d86c5b7b7

   1 Return-Path: <alex.boterolowry@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 5E2AC431FBC\r
   6         for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:55 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 Received: from olra.theworths.org ([127.0.0.1])\r
   9         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  10         with ESMTP id ORtmZOcBYcSH for <notmuch@notmuchmail.org>;\r
  11         Tue, 17 Nov 2009 16:23:54 -0800 (PST)\r
  12 Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com\r
  13         [209.85.160.51])\r
  14         by olra.theworths.org (Postfix) with ESMTP id 53BC2431FAE\r
  15         for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:54 -0800 (PST)\r
  16 Received: by pwj10 with SMTP id 10so330396pwj.30\r
  17         for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 16:23:53 -0800 (PST)\r
  18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  19         h=domainkey-signature:mime-version:received:date:message-id:subject\r
  20         :from:to:content-type;\r
  21         bh=y05RtVbdTG7OYYRov2eQDLEBYICZsfRA3FRPP9nrMMQ=;\r
  22         b=AkNoq9jCKNbJaqh+bELYXMD1a1lsj4PTCJKOhL1EiNKvEvJrwRrNn55CKMUBHOfQ75\r
  23         CvJVgWygDHA2AYMtFIik0Axn3Svztf71+Ls9jiQymS9zP9IcLGCsm+SUR9dun74iWxvf\r
  24         QNU1N0xXlnUqADRq/hoVrui4VbBf1sjA5EGBE=\r
  25 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  26         h=mime-version:date:message-id:subject:from:to:content-type;\r
  27         b=IXTiRksVsYYe71DPwZoAj1ou5XZOWuX1cGCf/CD8lyEf1V6bVDsO0v2efuJizBuzgs\r
  28         gZoU02whndlOIl1kwkgoCp+poe7xw7onwPeySJ2DY/QMsXQhwsnYTaYOKrANVBm3x3Ca\r
  29         75GT4xQKVIUUhLtlD97OAGfOuC+WxuIfabeYQ=\r
  30 MIME-Version: 1.0\r
  31 Received: by 10.114.186.37 with SMTP id j37mr5424456waf.36.1258503833548; Tue,\r
  32         17 Nov 2009 16:23:53 -0800 (PST)\r
  33 Date: Tue, 17 Nov 2009 16:23:53 -0800\r
  34 Message-ID: <cf0c4d610911171623q3e27a0adx802e47039b57604b@mail.gmail.com>\r
  35 From: Alex Botero-Lowry <alex.boterolowry@gmail.com>\r
  36 To: notmuch@notmuchmail.org\r
  37 Content-Type: multipart/mixed; boundary=0016e64ca4d8f27a4804789a4139\r
  38 Subject: [notmuch] [PATCH] Error out if no query is supplied to search\r
  39         instead of going into an infinite loop\r
  40 X-BeenThere: notmuch@notmuchmail.org\r
  41 X-Mailman-Version: 2.1.12\r
  42 Precedence: list\r
  43 List-Id: "Use and development of the notmuch mail system."\r
  44         <notmuch.notmuchmail.org>\r
  45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  46         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  48 List-Post: <mailto:notmuch@notmuchmail.org>\r
  49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  51         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  52 X-List-Received-Date: Wed, 18 Nov 2009 00:23:55 -0000\r
  53 \r
  54 --0016e64ca4d8f27a4804789a4139\r
  55 Content-Type: multipart/alternative; boundary=0016e64ca4d8f27a3604789a4137\r
  56 \r
  57 --0016e64ca4d8f27a3604789a4137\r
  58 Content-Type: text/plain; charset=ISO-8859-1\r
  59 \r
  60 In this case error out when no query is supplied. There seems to be an\r
  61 infinite-loop casued by i think notmuch_query_search_threads having\r
  62 an exception:\r
  63 \r
  64 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  65 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  66 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  67 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  68 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  69 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  70 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  71 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  72 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  73 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  74 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  75 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  76 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  77 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  78 A Xapian exception occurred: Syntax: <expression> AND <expression>\r
  79 \r
  80 I'll look into that bug specifically a bit later.\r
  81 \r
  82 It might be better to do a usage instead of just throwing an error here?\r
  83 \r
  84 alex\r
  85 \r
  86 --0016e64ca4d8f27a3604789a4137\r
  87 Content-Type: text/html; charset=ISO-8859-1\r
  88 \r
  89 In this case error out when no query is supplied. There seems to be an infinite-loop casued by i think notmuch_query_search_threads having<br>an exception:<br><br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>\r
  90 A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>\r
  91 A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>\r
  92 A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>\r
  93 A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>\r
  94 A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br>A Xapian exception occurred: Syntax: &lt;expression&gt; AND &lt;expression&gt;<br><br>I&#39;ll look into that bug specifically a bit later.<br>\r
  95 <br>It might be better to do a usage instead of just throwing an error here?<br><br>alex<br>\r
  96 \r
  97 --0016e64ca4d8f27a3604789a4137--\r
  98 \r
  99 --0016e64ca4d8f27a4804789a4139\r
 100 Content-Type: application/octet-stream; \r
 101         name="0001-Error-out-if-no-query-is-supplied-to-search-instead-.patch"\r
 102 Content-Disposition: attachment; \r
 103         filename="0001-Error-out-if-no-query-is-supplied-to-search-instead-.patch"\r
 104 Content-Transfer-Encoding: base64\r
 105 X-Attachment-Id: f_g25cms190\r
 106 \r
 107 RnJvbSAzZjk0MzFmNzRhNWZmNjZjODRjODY5YTNlMjZjMmJhZDQyYmVkMWIxIE1vbiBTZXAgMTcg\r
 108 MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgQm90ZXJvLUxvd3J5IDxhbGV4LmJvdGVyb2xv\r
 109 d3J5QGdtYWlsLmNvbT4KRGF0ZTogVHVlLCAxNyBOb3YgMjAwOSAxNjoyMDoyOCAtMDgwMApTdWJq\r
 110 ZWN0OiBbUEFUQ0hdIEVycm9yIG91dCBpZiBubyBxdWVyeSBpcyBzdXBwbGllZCB0byBzZWFyY2gg\r
 111 aW5zdGVhZCBvZiBnb2luZyBpbnRvIGFuIGluZmluaXRlIGxvb3AKCi0tLQogbm90bXVjaC1zZWFy\r
 112 Y2guYyB8ICAgIDUgKysrKysKIDEgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAwIGRl\r
 113 bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL25vdG11Y2gtc2VhcmNoLmMgYi9ub3RtdWNoLXNlYXJj\r
 114 aC5jCmluZGV4IDhkYjA5YzcuLmQ5NGZjY2QgMTAwNjQ0Ci0tLSBhL25vdG11Y2gtc2VhcmNoLmMK\r
 115 KysrIGIvbm90bXVjaC1zZWFyY2guYwpAQCAtNjYsNiArNjYsMTEgQEAgbm90bXVjaF9zZWFyY2hf\r
 116 Y29tbWFuZCAodm9pZCAqY3R4LCBpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgIGFyZ2MgLT0g\r
 117 aTsKICAgICBhcmd2ICs9IGk7CiAKKyAgICBpZiAoYXJnYyA9PSAwKSB7CisgICAgICAgIGZwcmlu\r
 118 dGYgKHN0ZGVyciwgIk5vIHF1ZXJ5IHByb3ZpZGVkXG4iKTsKKyAgICAgICAgcmV0dXJuIDE7Cisg\r
 119 ICAgfQorCiAgICAgY29uZmlnID0gbm90bXVjaF9jb25maWdfb3BlbiAoY3R4LCBOVUxMLCBOVUxM\r
 120 KTsKICAgICBpZiAoY29uZmlnID09IE5VTEwpCiAJcmV0dXJuIDE7Ci0tIAoxLjYuNS4yCgo=\r
 121 --0016e64ca4d8f27a4804789a4139--\r