1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 37D71431FD2
\r
6 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 22:15:15 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yEWDoFs2n24H for <notmuch@notmuchmail.org>;
\r
16 Tue, 24 Jan 2012 22:15:14 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 7089C431FB6
\r
21 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 22:15:14 -0800 (PST)
\r
22 Received: by wibhi8 with SMTP id hi8so2202085wib.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 22:15:13 -0800 (PST)
\r
24 Received: by 10.180.95.199 with SMTP id dm7mr25944401wib.9.1327472113432;
\r
25 Tue, 24 Jan 2012 22:15:13 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id hc10sm19248203wib.8.2012.01.24.22.15.11
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Tue, 24 Jan 2012 22:15:12 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id ECFAB9FD47; Wed, 25 Jan 2012 06:15:09 +0000 (GMT)
\r
33 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
34 notmuch@notmuchmail.org
\r
35 Subject: Re: [PATCH 1/3] emacs: Don't return the button from
\r
36 `notmuch-show-insert-part-header'.
\r
37 In-Reply-To: <87bopszxna.fsf@servo.finestructure.net>
\r
38 References: <1327052612-1040-1-git-send-email-dme@dme.org>
\r
39 <1327409620-10133-1-git-send-email-dme@dme.org>
\r
40 <1327409620-10133-2-git-send-email-dme@dme.org>
\r
41 <87k44hym3i.fsf@servo.finestructure.net>
\r
42 <cun8vkwq4ww.fsf@hotblack-desiato.hh.sledj.net>
\r
43 <87bopszxna.fsf@servo.finestructure.net>
\r
44 User-Agent: Notmuch/0.11+105~g08b3b0f (http://notmuchmail.org) Emacs/24.0.92.1
\r
45 (x86_64-pc-linux-gnu)
\r
46 From: David Edmondson <dme@dme.org>
\r
47 Date: Wed, 25 Jan 2012 06:15:06 +0000
\r
48 Message-ID: <cun4nvkpatx.fsf@hotblack-desiato.hh.sledj.net>
\r
50 Content-Type: multipart/signed; boundary="=-=-=";
\r
51 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
53 ALoCoQnlN1QN8OQTj9PnYhMxFxV4vDz3Gv52UN2dVQTCCrHalBarQdgIGuU5dTR/qIu/sTbjQLmu
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Wed, 25 Jan 2012 06:15:15 -0000
\r
69 Content-Type: text/plain
\r
70 Content-Transfer-Encoding: quoted-printable
\r
72 On Tue, 24 Jan 2012 11:52:09 -0800, Jameson Graef Rollins <jrollins@finestr=
\r
74 > On Tue, 24 Jan 2012 19:25:19 +0000, David Edmondson <dme@dme.org> wrote:
\r
75 > > On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins <jrollins@fin=
\r
76 estructure.net> wrote:
\r
77 > > > Is there a reason it's really necessary to make this change? Can't
\r
78 > > > callers just ignore the returned button if they don't care about it
\r
79 > > > further? I can see that maybe it's nice to be able to specify
\r
80 > > > parameters at creation time, but I'm not sure why that requires throw=
\r
82 > > > out the returned object as well.
\r
84 > > Patches 2 and 3 in that series can result in the button not being
\r
87 > Can patches 2 and 3 be rewritten so they are compatible with the button
\r
88 > being returned by the button creation function?
\r
90 No. The whole purpose of 2 and 3 is that they don't insert a button in
\r
91 some circumstances. If no button is inserted then there is no button to
\r
94 The changes to `notmuch-show-insert-part-multipart/signed' and
\r
95 `notmuch-show-insert-part-multipart/encrypted' in patch 1 could be
\r
96 re-written to anticipate that a button might not be returned, but the
\r
97 resulting code was more complex that that I sent.
\r
99 > > > I can see that maybe it's nice to be able to specify parameters at
\r
100 > > > creation time, but I'm not sure why that requires throwing out the
\r
101 > > > returned object as well.
\r
103 Do you have a specific use case for this?
\r
106 Content-Type: application/pgp-signature
\r
108 -----BEGIN PGP SIGNATURE-----
\r
109 Version: GnuPG v1.4.11 (GNU/Linux)
\r
111 iEYEARECAAYFAk8fneoACgkQaezQq/BJZRYxLwCfVU7BLe2QG91SPjoehqJ1YLZM
\r
112 FBgAnAzPRbV4a8T5YG+fxP5/+lT4yWa7
\r
114 -----END PGP SIGNATURE-----
\r