1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 1BAC86DE17ED
\r
6 for <notmuch@notmuchmail.org>; Tue, 8 Dec 2015 05:15:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.706 tagged_above=-999 required=5 tests=[AWL=0.054,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id e0RlS3NTyqh5 for <notmuch@notmuchmail.org>;
\r
16 Tue, 8 Dec 2015 05:15:03 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 70A5F6DE17CB
\r
19 for <notmuch@notmuchmail.org>; Tue, 8 Dec 2015 05:15:03 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1FEEB10004A;
\r
22 Tue, 8 Dec 2015 15:15:09 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
\r
26 In-Reply-To: <87egexyusl.fsf@zancas.localnet>
\r
27 References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>
\r
28 <87egexyusl.fsf@zancas.localnet>
\r
29 User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Tue, 08 Dec 2015 15:15:09 +0200
\r
35 Message-ID: <m27fkpozdu.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.20
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Tue, 08 Dec 2015 13:15:06 -0000
\r
52 On Tue, Dec 08 2015, David Bremner <david@tethera.net> wrote:
\r
54 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
56 >> Some compilers (older than gcc 4.5 and clang 2.9) do support
\r
57 >> __attribute__ ((deprecated)) but not
\r
58 >> __attribute__ ((deprecated("message"))).
\r
60 >> Check (clang) and know (gcc) which versions support which variants
\r
61 >> and make two definitions of define NOTMUCH_DEPRECATED macro;
\r
62 >> one with and and one without the ("message") part.
\r
64 >> __has_extension() replacement was modeled after __has_attribute()
\r
65 >> definition in compat/function-attributes.h. Thanks Justus.
\r
69 > I keep coming back to review this patch, but I'm blocked by the fact
\r
70 > that clang++ is broken on Debian (and lots of other places, I guess) for
\r
73 > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038
\r
75 Personally I am not fond of the commit message but I don't want to
\r
76 emphasize the change by sending an updated one. We could move it
\r
77 to *moreinfo* to get it out of our ways for the time being -- and
\r
78 see whether things stabilize (to one way or another) to decide
\r
79 whether to push this further.
\r