1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4A97E431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 21 Jan 2013 10:09:15 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id tqGJYpgG3enF for <notmuch@notmuchmail.org>;
\r
16 Mon, 21 Jan 2013 10:09:14 -0800 (PST)
\r
17 Received: from mail-bk0-f48.google.com (mail-bk0-f48.google.com
\r
18 [209.85.214.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 94396431FAE
\r
21 for <notmuch@notmuchmail.org>; Mon, 21 Jan 2013 10:09:14 -0800 (PST)
\r
22 Received: by mail-bk0-f48.google.com with SMTP id jk14so676481bkc.21
\r
23 for <notmuch@notmuchmail.org>; Mon, 21 Jan 2013 10:09:13 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=V1YWDI/hBqeZMU0msR2LbWUnnD+6J1bgDD+G2bbRbmo=;
\r
29 b=Tf+giVbpOxyulW+7j6GbmTqJm9aMQt/CqhOg86nDA4ea4bvMo/47Q0C9r4DbtfdM/U
\r
30 uo8QB0UONnRh+NdgEPXgJqi3xZdY9gO3QXC574q0xo2BIiBVhnBqBt40ciU5x9FDoCnb
\r
31 FwoqXXeRvNDIkSDq7u/15Bh3mIwmzbeJC0wHjDA16Lfx+VPF8R7CseSYWSI4lkiKLT4x
\r
32 XqdYSYJovp3MRQHwIXAqjIsniwoW0DhAW0eGNOpPG+3aQXUh5kbyGcgNZSwME6KzkDhJ
\r
33 ks9NW1xin8PK1XWr2AZiRpvytyDZZ/661BSyMkm6Sn/fejhnkpJbWLbIz7ZbaufKwkx4
\r
35 X-Received: by 10.204.149.11 with SMTP id r11mr4940260bkv.93.1358791753124;
\r
36 Mon, 21 Jan 2013 10:09:13 -0800 (PST)
\r
37 Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])
\r
38 by mx.google.com with ESMTPS id y11sm9235154bkw.8.2013.01.21.10.09.10
\r
39 (version=TLSv1.1 cipher=RC4-SHA bits=128/128);
\r
40 Mon, 21 Jan 2013 10:09:11 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH v3 07/20] tag-util: do not reset list in
\r
44 parse_tag_command_line
\r
45 In-Reply-To: <1358643004-14522-8-git-send-email-novalazy@gmail.com>
\r
46 References: <1358643004-14522-1-git-send-email-novalazy@gmail.com>
\r
47 <1358643004-14522-8-git-send-email-novalazy@gmail.com>
\r
48 User-Agent: Notmuch/0.14+259~gdee88db (http://notmuchmail.org) Emacs/23.2.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Mon, 21 Jan 2013 19:09:04 +0100
\r
51 Message-ID: <878v7m2ytb.fsf@nikula.org>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
55 ALoCoQlVxLKOvt7ikoTdSrVLp6SXrD8pMom0NFKRCS7FKgN49gfJcASisalTuIbJHBW8MEungHAR
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Mon, 21 Jan 2013 18:09:15 -0000
\r
70 On Sun, 20 Jan 2013, Peter Wang <novalazy@gmail.com> wrote:
\r
71 > No current callers of parse_tag_command_line require that it clear its
\r
72 > tag list argument. The notmuch 'insert' command will be better served
\r
73 > if the function modifies a pre-populated list (of new.tags) instead of
\r
74 > clobbering it outright.
\r
76 I think I'd like parse_tag_command_line() and parse_tag_line() to behave
\r
77 similarly, both either resetting or not resetting tag list. I think you
\r
78 could just parse command line first, and add new.tags afterwards, and
\r
79 you'd be fine without changing parse_tag_command_line().
\r
84 > 2 files changed, 2 insertions(+), 2 deletions(-)
\r
86 > diff --git a/tag-util.c b/tag-util.c
\r
87 > index 701d329..3f9da05 100644
\r
90 > @@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
\r
94 > - tag_op_list_reset (tag_ops);
\r
96 > for (i = 0; i < argc; i++) {
\r
97 > if (strcmp (argv[i], "--") == 0) {
\r
99 > diff --git a/tag-util.h b/tag-util.h
\r
100 > index 246de85..4628f16 100644
\r
103 > @@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
\r
104 > * Output Parameters:
\r
105 > * ops contains a list of tag operations
\r
106 > * query_str the search terms.
\r
108 > + * The ops argument is not cleared.
\r
111 > tag_parse_status_t
\r
115 > _______________________________________________
\r
116 > notmuch mailing list
\r
117 > notmuch@notmuchmail.org
\r
118 > http://notmuchmail.org/mailman/listinfo/notmuch
\r