1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 15064431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 8 Oct 2013 09:49:13 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id svJ-H3Kn8jJu for <notmuch@notmuchmail.org>;
\r
17 Tue, 8 Oct 2013 09:49:05 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 419DB431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 8 Oct 2013 09:49:05 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1VTaSz-0006DC-3V; Tue, 08 Oct 2013 17:49:04 +0100
\r
27 Received: from 92.40.123.1.threembb.co.uk ([92.40.123.1] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1VTaSx-0001dR-Fv; Tue, 08 Oct 2013 17:49:00 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 10/11] emacs: Add known-broken tests for search tagging
\r
35 In-Reply-To: <1381185201-25197-11-git-send-email-amdragon@mit.edu>
\r
36 References: <1381185201-25197-1-git-send-email-amdragon@mit.edu>
\r
37 <1381185201-25197-11-git-send-email-amdragon@mit.edu>
\r
38 User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Tue, 08 Oct 2013 17:47:51 +0100
\r
41 Message-ID: <87txgraevc.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 92.40.123.1
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: bdadf64c4de06e38c4475b195cb32ab1 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: 0.0
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored 0.0 points. Summary of the scoring:
\r
53 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
54 provider * (markwalters1009[at]gmail.com)
\r
55 X-QM-Scan-Virus: ClamAV says the message is clean
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 08 Oct 2013 16:49:13 -0000
\r
71 On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
72 > These tests check that both thread-local and global search tagging
\r
73 > operations are race-free. They are currently known-broken because
\r
74 > they aren't race-free.
\r
76 > test/emacs | 26 ++++++++++++++++++++++++++
\r
77 > 1 file changed, 26 insertions(+)
\r
79 > diff --git a/test/emacs b/test/emacs
\r
80 > index 2917189..e0dcd3c 100755
\r
83 > @@ -922,4 +922,30 @@ This is a warning (see *Notmuch errors* for more details)
\r
85 > This is another warning"
\r
87 > +test_begin_subtest "Search thread tag operations are race-free"
\r
88 > +test_subtest_known_broken
\r
89 > +add_message '[subject]="Search race test"'
\r
90 > +gen_msg_id_1=$gen_msg_id
\r
91 > +generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \
\r
92 > + '[references]="<'$gen_msg_id_1'>"' \
\r
93 > + '[subject]="Search race test two"'
\r
94 > +test_emacs '(notmuch-search "subject:\"search race test\"")
\r
95 > + (notmuch-test-wait)
\r
97 > + (execute-kbd-macro "+search-thread-race-tag")'
\r
98 > +output=$(notmuch search --output=messages 'tag:search-thread-race-tag')
\r
99 > +test_expect_equal "$output" "id:$gen_msg_id_1"
\r
101 > +test_begin_subtest "Search global tag operations are race-free"
\r
102 > +test_subtest_known_broken
\r
103 > +generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \
\r
104 > + '[references]="<'$gen_msg_id_1'>"' \
\r
105 > + '[subject]="Re: Search race test"'
\r
106 > +test_emacs '(notmuch-search "subject:\"search race test\" -subject:two")
\r
107 > + (notmuch-test-wait)
\r
109 > + (execute-kbd-macro "*+search-global-race-tag")'
\r
110 > +output=$(notmuch search --output=messages 'tag:search-global-race-tag')
\r
111 > +test_expect_equal "$output" "id:$gen_msg_id_1"
\r
115 For the global tagging test would it be worth also adding a matching
\r
116 message in a different thread?
\r
127 > _______________________________________________
\r
128 > notmuch mailing list
\r
129 > notmuch@notmuchmail.org
\r
130 > http://notmuchmail.org/mailman/listinfo/notmuch
\r