1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 73C09429E25
\r
6 for <notmuch@notmuchmail.org>; Mon, 5 Dec 2011 03:39:40 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id vR5mipjWTMET for <notmuch@notmuchmail.org>;
\r
16 Mon, 5 Dec 2011 03:39:39 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 2E337429E21
\r
21 for <notmuch@notmuchmail.org>; Mon, 5 Dec 2011 03:39:39 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pB5BcWBM019807;
\r
24 Mon, 5 Dec 2011 13:39:33 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs0m8kg-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Mon, 05 Dec 2011 13:39:33 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 pB5BdWMk012916; Mon, 5 Dec 2011 13:39:32 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
34 Subject: [PATCH] make release: remove LATEST-$(PACKAGE)-*
\r
35 In-Reply-To: <87y5utsdys.fsf@rocinante.cs.unb.ca>
\r
36 References: <yf6ty5ttfs2.fsf@taco2.nixu.fi>
\r
37 <87y5utsdys.fsf@rocinante.cs.unb.ca>
\r
38 User-Agent: Notmuch/0.10+55~gde3d46e (http://notmuchmail.org) Emacs/23.3.1
\r
40 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
41 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
42 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
43 Date: Mon, 05 Dec 2011 13:39:32 +0200
\r
44 Message-ID: <yf6born5jt7.fsf@taco2.nixu.fi>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
48 1.0.211, 0.0.0000 definitions=2011-12-05_02:2011-12-04, 2011-12-05,
\r
49 1970-01-01 signatures=0
\r
50 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
51 ipscore=0 suspectscore=0
\r
52 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
54 scancount=1 engine=6.0.2-1012030000 definitions=main-1112050053
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Mon, 05 Dec 2011 11:39:40 -0000
\r
69 The tar file of particular package (notmuch in this case) is named
\r
70 as $(PACKAGE)-$(VERSION).tar.gz. Therefore the best way to remove
\r
71 previous link to LATEST is to remove all files beginning with
\r
72 LATEST-$(PACKAGE)- and not relying how $(VERSION) string is constructed.
\r
75 Applies on top of id:"yf6ty5ttfs2.fsf@taco2.nixu.fi"
\r
77 More discussion at the end of this email.
\r
79 Makefile.local | 2 +-
\r
80 1 files changed, 1 insertions(+), 1 deletions(-)
\r
82 diff --git a/Makefile.local b/Makefile.local
\r
83 index b4faada..d699463 100644
\r
84 --- a/Makefile.local
\r
85 +++ b/Makefile.local
\r
86 @@ -122,7 +122,7 @@ release: verify-source-tree-and-version
\r
87 ifeq ($(REALLY_UPLOAD),yes)
\r
88 git push origin $(VERSION)
\r
89 cd releases && scp $(TAR_FILE) $(SHA1_FILE) $(GPG_FILE) $(RELEASE_HOST):$(RELEASE_DIR)
\r
90 - ssh $(RELEASE_HOST) "rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-[0-9]* ; ln -s $(TAR_FILE) $(RELEASE_DIR)/LATEST-$(TAR_FILE)"
\r
91 + ssh $(RELEASE_HOST) "rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-* ; ln -s $(TAR_FILE) $(RELEASE_DIR)/LATEST-$(TAR_FILE)"
\r
93 @echo "Please send a release announcement using $(PACKAGE)-$(VERSION).announce as a template."
\r
98 Subject: Re: [PATCH] have LATEST-notmuch-<version>.tar.gz on releases web page
\r
100 On Sat, 03 Dec 2011 10:32:43 -0800, David Bremner <david@tethera.net> wrote:
\r
101 > On Thu, 24 Nov 2011 22:41:01 +0200, Tomi Ollila <tomi.ollila@nixu.com> wrote:
\r
102 > > The notmuchmail/releases page used to have LATEST-notmuch-<version>
\r
103 > > to link to the latest notmuch source tarball. This is confusing on
\r
104 > > web page and on disk when the file has been downloaded. This change
\r
105 > > looks a bit inconsistent with the 'rm' command just executed before.
\r
106 > > $(TAR_FILE) is defined (currently) as $(PACKAGE)-$(VERSION).tar.gz;
\r
107 > > as long as the prefix stays $(PACKAGE)-$(VERSION) and version begins
\r
108 > > with a digit then this line is good in execution point of view.
\r
110 > On IRC we talked about changing the rm command in this since I
\r
111 > bootstrapped the process by hand. Did you come to a conclusion one way
\r
114 Yes. IMO Instead of rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-[0-9]*
\r
115 this should just be rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-*
\r
117 This change and the patch in question are independent of each other
\r
118 as the former would fail to remove the LATEST- -file if $(VERSION)
\r
119 started without number in any case.
\r
121 I don't see anything else that could be used to make rm more consistent
\r
122 in case the -$(PACKAGE)-$(VERSION) is changed to -$(TAR_FILE) -- still, it
\r
123 would be silly to use -$(PACKAGE)-$(VERSION).tar.gz there; also this definition
\r
125 TAR_FILE=$(PACKAGE)-$(VERSION).tar.gz
\r
127 in Makefile.local looks pretty robust.
\r