1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 15BC7431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 22 Aug 2012 23:26:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id GyHEtslHUU18 for <notmuch@notmuchmail.org>;
\r
16 Wed, 22 Aug 2012 23:25:59 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 18DF1431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 22 Aug 2012 23:25:59 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 82465100386; Thu, 23 Aug 2012 09:26:06 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>
\r
24 Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact
\r
25 In-Reply-To: <87haruxiae.fsf@kaki.tech.prive.nic.fr>
\r
26 References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>
\r
27 <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com>
\r
28 <m27gssitot.fsf@guru.guru-group.fi> <87y5l8z4dw.fsf@gmail.com>
\r
29 <m2txvv794d.fsf@guru.guru-group.fi>
\r
30 <87haruxiae.fsf@kaki.tech.prive.nic.fr>
\r
31 User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1
\r
32 (x86_64-redhat-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Thu, 23 Aug 2012 09:26:06 +0300
\r
37 Message-ID: <m2harucef5.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain; charset=utf-8
\r
40 Content-Transfer-Encoding: quoted-printable
\r
41 Cc: notmuch <notmuch@notmuchmail.org>
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Thu, 23 Aug 2012 06:26:00 -0000
\r
56 On Thu, Aug 23 2012, Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr> wrote:
\r
58 > Tomi Ollila=C2=A0:
\r
60 >> On Tue, Aug 21 2012, Ben Gamari wrote:
\r
62 >>> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the
\r
65 >> Presuming that those variables are always numeric the comparison could b=
\r
68 >> if [ ${xapian_major_version} -gt 1 ] ||=20
\r
69 >> [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] ||=
\r
71 >> [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \
\r
72 >> ${xapian_subminor_version} -ge 6 ]; then
\r
74 >> (I could not figure out anything shorter and/or cleaner)
\r
78 > case "${xapian_version}" in
\r
79 > 0.*|1.[01].*|1.2.[0-5]) ;;
\r
83 That sure is shorter -- and splitting xapian_version
\r
86 .. also that would take care the (improbable?) case that
\r
87 `${xapian_config} -- version` outputs something else than
\r
88 #.#.# in the future.
\r
90 On the other hand, the above doesn't catch junk, so maybe:
\r
92 case ${xapian_version} in
\r
93 0.*|1.[01].*|1.2.[0-5]) handle no case ;;=20=20
\r
94 [1-9]*.[0-9]*.[0-9]*) handle yes case -- approximated test ;;
\r
98 (and we (approximately) expect #.#.#)
\r
100 In any case, excellent idea !
\r