c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 13C36431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:48 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id H-+Y40agq3vZ for <notmuch@notmuchmail.org>;\r
  16         Wed, 11 Sep 2013 10:40:42 -0700 (PDT)\r
  17 Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com\r
  18         [209.85.215.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  19         (No client certificate requested)\r
  20         by olra.theworths.org (Postfix) with ESMTPS id B85E2431FAE\r
  21         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:41 -0700 (PDT)\r
  22 Received: by mail-ea0-f179.google.com with SMTP id b10so4748694eae.38\r
  23         for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:40 -0700 (PDT)\r
  24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25         d=1e100.net; s=20130820;\r
  26         h=x-gm-message-state:from:to:subject:in-reply-to:references\r
  27         :user-agent:date:message-id:mime-version:content-type;\r
  28         bh=OzoFLp4k296bUnYpJLWXSi47o9GRucF/CHjQyA0spC0=;\r
  29         b=Ynxye6f1fngtEHvPT5mBb6JeRwsiLFPVHD43Tl7hFUxqYjmaTtIJOTHNzpYCRmbNYn\r
  30         HKAdBhWajCmkGP3RPisbmjHQZUQ1ydnZMJ6QJoV5bss3ETvXNL6fqY2M2z97/mTTNz+N\r
  31         3TcA40vN8YRNgAuDqN83OTB77tJhUuIE9Y8I8CgK1HDx7RGX4o4Se+ni+/LXYUHmCZyX\r
  32         CndPMDYXqPneCDndPyF5tgjJHaOjGB4fmAA3t28wr+iL6XD2SFRC9XpTftR6xHn7C2mL\r
  33         WS1koRPYbbxNRM5noEBYGevxMLDvPQ7JBwSE0Qg9zwsh+Rkcf6HwZXuRAhueCbEDR77X\r
  34         fWig==\r
  35 X-Gm-Message-State:\r
  36  ALoCoQnq80MzzB0EYLoS0AQCa0MOLOCtxz5SBLOoAyHxsrJr/Y7YLh7uVqn8D8qsv7sCBv0RCcvw\r
  37 X-Received: by 10.14.8.72 with SMTP id 48mr3927478eeq.25.1378921240464;\r
  38         Wed, 11 Sep 2013 10:40:40 -0700 (PDT)\r
  39 Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
  40         [88.195.111.91])\r
  41         by mx.google.com with ESMTPSA id a43sm42119643eep.9.1969.12.31.16.00.00\r
  42         (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
  43         Wed, 11 Sep 2013 10:40:39 -0700 (PDT)\r
  44 From: Jani Nikula <jani@nikula.org>\r
  45 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
  46 Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to\r
  47         g_mime_init()\r
  48 In-Reply-To: <8738pcjet4.fsf@awakening.csail.mit.edu>\r
  49 References: <1378839078-6298-1-git-send-email-jani@nikula.org>\r
  50         <8738pcjet4.fsf@awakening.csail.mit.edu>\r
  51 User-Agent: Notmuch/0.16+74~g35e4af5 (http://notmuchmail.org) Emacs/24.3.1\r
  52         (x86_64-pc-linux-gnu)\r
  53 Date: Wed, 11 Sep 2013 20:40:40 +0300\r
  54 Message-ID: <87vc27p887.fsf@nikula.org>\r
  55 MIME-Version: 1.0\r
  56 Content-Type: text/plain\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Wed, 11 Sep 2013 17:40:48 -0000\r
  70 \r
  71 On Wed, 11 Sep 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
  72 > LGTM in principle, though I'd like to see a test of some of the\r
  73 > malformed RFC 2047 that this lets us decode.  Is there a summary\r
  74 > somewhere of exactly what these workarounds enable?\r
  75 \r
  76 Not that I know of; looking into gmime source it's mostly about encoded\r
  77 words without surrounding space, or space within encoded words.\r
  78 \r
  79 v2 now has known broken tests for known broken encodings...\r
  80 \r
  81 > This isn't directly related to this patch, but is there a reason we\r
  82 > g_mime_init in so many different places?  Both the CLI and\r
  83 > notmuch_database_open I can understand because the CLI also uses GMime\r
  84 > and should be sure it's initialized.  Maaaybe\r
  85 > notmuch_message_file_get_header because notmuch_message_file\r
  86 > theoretically independent of the database, even though I don't think\r
  87 > it's possible to call into it without first calling\r
  88 > notmuch_database_open.  But _notmuch_message_index_file?\r
  89 \r
  90 I noted the same, but decided it's another patch, another time.\r
  91 \r
  92 \r
  93 BR,\r
  94 Jani.\r