1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 67C26431FBD
\r
6 for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 07:54:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 9Nn0VvCmw2oP for <notmuch@notmuchmail.org>;
\r
16 Sun, 13 Jul 2014 07:54:52 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 48679431FBC
\r
21 for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 07:54:52 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1X6LAx-0007Qj-IU; Sun, 13 Jul 2014 11:54:51 -0300
\r
25 Received: (nullmailer pid 3045 invoked by uid 1000); Sun, 13 Jul 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 2/2] Make parsing of References and In-Reply-To header
\r
31 In-Reply-To: <1401113157-32454-3-git-send-email-sojkam1@fel.cvut.cz>
\r
32 References: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>
\r
33 <1401113157-32454-3-git-send-email-sojkam1@fel.cvut.cz>
\r
34 User-Agent: Notmuch/0.18.1+29~gb5327d4 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-pc-linux-gnu)
\r
36 Date: Sun, 13 Jul 2014 11:54:48 -0300
\r
37 Message-ID: <8761j1fgw7.fsf@maritornes.cs.unb.ca>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Sun, 13 Jul 2014 14:54:59 -0000
\r
54 Michal Sojka <sojkam1@fel.cvut.cz> writes:
\r
56 > According to RFC2822 References and In-Reply-To headers are supposed
\r
57 > to contain one or more Message-IDs, however older RFC822 allowed
\r
58 > almost any content. When both References and In-Reply-To headers ends
\r
59 > with something else that a Message-ID (see e.g. [1]), the thread
\r
60 > structure presented by notmuch is incorrect. The reason is that
\r
61 > notmuch treats this case as if the email contained no "replyto"
\r
62 > information (see _notmuch_database_link_message_to_parents).
\r
64 > This patch changes the parse_references() function to return the last
\r
65 > valid Message-ID encountered rather than NULL resulting from the last
\r
66 > hunk of text not being the Message-ID.
\r
68 This series looks OK to me. It does touch something pretty fundamental,
\r
69 so I'd appreciate a second set of eyes on it.
\r