1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16290431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:27 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 9zyYtblCI+-0 for <notmuch@notmuchmail.org>;
\r
16 Sun, 15 Apr 2012 10:33:26 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 571AC431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:33:26 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 2C42E68055; Sun, 15 Apr 2012 20:33:22 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,
\r
24 notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the
\r
26 cursor is at the end of the buffer.
\r
27 In-Reply-To: <87lilw6hnw.fsf@qmul.ac.uk>
\r
28 References: <1327996914-9644-1-git-send-email-dme@dme.org>
\r
29 <1327996914-9644-3-git-send-email-dme@dme.org>
\r
30 <87lilw6hnw.fsf@qmul.ac.uk>
\r
31 User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Sun, 15 Apr 2012 20:33:22 +0300
\r
37 Message-ID: <m2iph0sxwd.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain; charset=us-ascii
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Sun, 15 Apr 2012 17:33:27 -0000
\r
54 On Sun, Apr 15 2012, Mark Walters wrote:
\r
56 > On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:
\r
57 >> When using the spacebar to scroll through a thread, hitting 'space'
\r
58 >> when the bottom of the last message is visible should take the cursor
\r
59 >> to the end of the buffer rather than immediately archiving the thread
\r
60 >> and moving to the next thread.
\r
64 > This patch looks good to me; (but if people prefer the current behaviour then
\r
65 > can we mark this notmuch::wontfix so it leaves the review queue)
\r
67 I would definitely like to see this patch applied. Less surprising
\r
68 as there is no indication we have reached the bottom of the buffer.
\r
79 >> emacs/notmuch-show.el | 5 +++++
\r
80 >> 1 files changed, 5 insertions(+), 0 deletions(-)
\r
82 >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
83 >> index ec72ff8..3f54de0 100644
\r
84 >> --- a/emacs/notmuch-show.el
\r
85 >> +++ b/emacs/notmuch-show.el
\r
86 >> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
\r
87 >> ;; This is not the last message - move to the next visible one.
\r
88 >> (notmuch-show-next-open-message))
\r
90 >> + ((not (= (point) (point-max)))
\r
91 >> + ;; This is the last message, but the cursor is not at the end of
\r
92 >> + ;; the buffer. Move it there.
\r
93 >> + (goto-char (point-max)))
\r
96 >> ;; This is the last message - change the return value
\r
101 >> _______________________________________________
\r
102 >> notmuch mailing list
\r
103 >> notmuch@notmuchmail.org
\r
104 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r
105 > _______________________________________________
\r
106 > notmuch mailing list
\r
107 > notmuch@notmuchmail.org
\r
108 > http://notmuchmail.org/mailman/listinfo/notmuch
\r