1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C46A1431FC3
\r
6 for <notmuch@notmuchmail.org>; Fri, 9 Mar 2012 17:26:32 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id zjD6JEPxNir5 for <notmuch@notmuchmail.org>;
\r
17 Fri, 9 Mar 2012 17:26:32 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 232C6431FBC
\r
22 for <notmuch@notmuchmail.org>; Fri, 9 Mar 2012 17:26:32 -0800 (PST)
\r
23 Received: by bkwj4 with SMTP id j4so1791450bkw.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 09 Mar 2012 17:26:30 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;
\r
27 bh=hY3rBCqQooueK7mqUgA0UDlErn9H/dO2MM/yrDX4Sh4=;
\r
28 b=IIt056a6wMuDtd53+DhqLuZfHy7DVefsqhmcDGlMqnmTx3a06NZgqWl44orKFZitXg
\r
29 UyRA01f9MrmAs9thoMLJqkU8puPCHYji5aLX1AyqjZxp3tu4AtvfOYiFbFAh0voMeJ0S
\r
30 KbZ5xHiX+rTOjyWJ/Ee63qBFvJ/zxDCvScw+2IOECm72rwForepfjRmuI4WvtR4ySk+1
\r
31 A58sUle51jBZspqyQTBRWNLFIG0UBqH1xOMk+iGh1/nmVfscWAV9xBdrtUOS/kwpFsSW
\r
32 S2qKrtJbrKD47YkhvhvbiM4/iobWZkye9vwUxNki/rdEqNJKuBsfgqnL+y87W6nsmqLX
\r
34 Received: by 10.204.156.12 with SMTP id u12mr1804622bkw.33.1331342790707;
\r
35 Fri, 09 Mar 2012 17:26:30 -0800 (PST)
\r
36 Received: from localhost ([91.144.186.21])
\r
37 by mx.google.com with ESMTPS id jw10sm137654bkb.10.2012.03.09.17.26.29
\r
38 (version=TLSv1/SSLv3 cipher=OTHER);
\r
39 Fri, 09 Mar 2012 17:26:29 -0800 (PST)
\r
40 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
41 To: notmuch@notmuchmail.org
\r
42 Subject: [PATCH v2 1/2] test: remove "Generate some messages" test from raw
\r
43 Date: Sat, 10 Mar 2012 05:24:50 +0400
\r
44 Message-Id: <1331342691-26899-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 X-Mailer: git-send-email 1.7.9.1
\r
46 In-Reply-To: <1331342691-26899-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
47 References: <1327961195-4204-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
48 <1331342691-26899-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Sat, 10 Mar 2012 01:26:32 -0000
\r
63 Before the change, the first subtest in raw format tests just
\r
64 generated messages and checked that they are added successfully. This
\r
65 is not really a raw format test, it is creating of environment
\r
66 required for other subtests to run. The patch removes the first
\r
67 subtest from raw and replaces it with bare add_message calls, similar
\r
68 to how it is done in other tests.
\r
70 TODO: we should check that test environment was created successfully.
\r
71 Currently, many tests do add_message(), notmuch new and other calls
\r
72 without checking the results. We should come up with a general
\r
73 solution for this, i.e. if any command during test initialization
\r
74 fails, all tests should be skipped with appropriate error message.
\r
76 test/raw | 7 ++-----
\r
77 1 files changed, 2 insertions(+), 5 deletions(-)
\r
79 diff --git a/test/raw b/test/raw
\r
80 index 0171e64..de0b867 100755
\r
84 test_description='notmuch show --format=raw'
\r
87 -test_begin_subtest "Generate some messages"
\r
90 -output=$(NOTMUCH_NEW)
\r
91 -test_expect_equal "$output" "Added 2 new messages to the database."
\r
95 test_begin_subtest "Attempt to show multiple raw messages"
\r
96 output=$(notmuch show --format=raw "*" 2>&1)
\r