1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6FD36429E25
\r
6 for <notmuch@notmuchmail.org>; Fri, 11 Nov 2011 13:06:57 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id dZOZV8ysFhC7 for <notmuch@notmuchmail.org>;
\r
17 Fri, 11 Nov 2011 13:06:56 -0800 (PST)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 6DC8F431FB6
\r
22 for <notmuch@notmuchmail.org>; Fri, 11 Nov 2011 13:06:56 -0800 (PST)
\r
23 Received: by bkaq10 with SMTP id q10so4343711bka.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 11 Nov 2011 13:06:53 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=yWBTuF14DHaUsLUVRfk8mGXjNHmYVfwVNqEjebs+G10=;
\r
29 b=Lam4MNceIjMfOk1RmAOLzgpV1DolIa4JrTNirJpfY0u/lbJMzzyYs7zXb+GvBvG7Bt
\r
30 YofGQbCIGkf4ndsAbTY0d2oR9jRy0iexJjDt1aXX2jw4PjlBmSJJdK0Fn4Qr54ESKYHK
\r
31 tdu5q34atbRYkbayyOmkZhv5HeWL9tKo1mlqc=
\r
32 Received: by 10.204.157.154 with SMTP id b26mr2468422bkx.52.1321045613580;
\r
33 Fri, 11 Nov 2011 13:06:53 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id o8sm13224004bkd.3.2011.11.11.13.06.52
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Fri, 11 Nov 2011 13:06:52 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Tomi Ollila <too@iki.fi>,
\r
40 Jameson Graef Rollins <jrollins@finestructure.net>,
\r
41 Notmuch Mail <notmuch@notmuchmail.org>
\r
42 Subject: Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests
\r
43 In-Reply-To: <yf64nyae67m.fsf@taco2.nixu.fi>
\r
44 References: <yf6mxc3ab4t.fsf@taco2.nixu.fi>
\r
45 <1320963737-1666-1-git-send-email-jrollins@finestructure.net>
\r
46 <yf64nyae67m.fsf@taco2.nixu.fi>
\r
47 User-Agent: Notmuch/0.9+55~g81c615b (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Sat, 12 Nov 2011 01:06:40 +0400
\r
50 Message-ID: <87fwhu2wtb.fsf@gmail.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 11 Nov 2011 21:06:57 -0000
\r
67 On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila <too@iki.fi> wrote:
\r
68 > dtach is simpler than screen and is not setuid/setgid program so
\r
69 > TMPDIR does not get cleared by dynamic loader when executed.
\r
72 > Updated version after discussion with DmitryKurochkin and amdragon
\r
73 > on IRC. Thank you.
\r
76 Looks good to me (though I did not test it).
\r
78 Few minor comments below.
\r
80 > test/test-lib.sh | 25 +++++++++++++------------
\r
81 > 1 files changed, 13 insertions(+), 12 deletions(-)
\r
83 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
84 > index c81c709..c232130 100755
\r
85 > --- a/test/test-lib.sh
\r
86 > +++ b/test/test-lib.sh
\r
87 > @@ -39,7 +39,7 @@ done,*)
\r
91 > -# Keep the original TERM for say_color
\r
92 > +# Keep the original TERM for say_color and emacs tests
\r
94 s/emacs tests/test_emacs/ for consistency with say_color?
\r
96 > ORIGINAL_TERM=$TERM
\r
98 > # For repeatability, reset the environment to known value.
\r
99 > @@ -843,12 +841,15 @@ EOF
\r
101 > if [ -z "$EMACS_SERVER" ]; then
\r
102 > EMACS_SERVER="notmuch-test-suite-$$"
\r
103 > - # start a detached screen session with an emacs server
\r
104 > - screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \
\r
105 > - --no-window-system \
\r
106 > - --eval "(setq server-name \"$EMACS_SERVER\")" \
\r
107 > - --eval '(server-start)' \
\r
108 > - --eval "(orphan-watchdog $$)" || return
\r
109 > + # start a detached session with an emacs server
\r
110 > + # user's TERM is given to dtach which assumes a minimally
\r
111 > + # VT100-compatible terminal -- and emacs inherits that
\r
112 > + TERM=$ORIGINAL_TERM dtach -n "$TMP_DIRECTORY/emacs-dtach-socket.$$" \
\r
113 > + sh -c "stty rows 24 cols 80; exec '$TMP_DIRECTORY/run_emacs' \
\r
115 The above line has a space after two tabs.
\r
120 > + --no-window-system \
\r
121 > + --eval '(setq server-name \"$EMACS_SERVER\")' \
\r
122 > + --eval '(server-start)' \
\r
123 > + --eval '(orphan-watchdog $$)'" || return
\r
124 > # wait until the emacs server is up
\r
125 > until test_emacs '()' 2>/dev/null; do
\r
130 > _______________________________________________
\r
131 > notmuch mailing list
\r
132 > notmuch@notmuchmail.org
\r
133 > http://notmuchmail.org/mailman/listinfo/notmuch
\r