1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 41D2C431FD0
\r
6 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 06:41:17 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.7 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id vA-2SkUAHBfr for <notmuch@notmuchmail.org>;
\r
18 Sat, 17 Dec 2011 06:41:16 -0800 (PST)
\r
19 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
20 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
21 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
22 6C8B2431FB6 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 06:41:16 -0800
\r
24 Received: by wgbds13 with SMTP id ds13so6436659wgb.2
\r
25 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 06:41:14 -0800 (PST)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
27 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
28 :mime-version:content-type;
\r
29 bh=tAKHGPZe1kPUP6bgtKUFi7+OBmshrLHvdUEMpz7myyM=;
\r
30 b=eI5tADTZkID7sPrq6edzPrKf6cYPSFbS3UHegva4ivegwpZwMKjorZHf0mwmpIW0rn
\r
31 NGYbBz11HF2t9f4tpEEjHIUlmXZP4IKEHR9HtzgegyFRFE6wSoGo2uPdci/MQPjG5+WX
\r
32 Y9hhW3vMBsbXffkSuKD/ia3aCYmBSeYPGvhFw=
\r
33 Received: by 10.180.105.232 with SMTP id gp8mr17896460wib.65.1324132871728;
\r
34 Sat, 17 Dec 2011 06:41:11 -0800 (PST)
\r
35 Received: from localhost ([91.144.186.21])
\r
36 by mx.google.com with ESMTPS id w8sm17637724wiz.4.2011.12.17.06.41.09
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Sat, 17 Dec 2011 06:41:10 -0800 (PST)
\r
39 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
40 To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail
\r
42 In-Reply-To: <1324118488-81437-1-git-send-email-aaronecay@gmail.com>
\r
43 References: <yf6wr9v4hu1.fsf@taco2.nixu.fi>
\r
44 <1324118488-81437-1-git-send-email-aaronecay@gmail.com>
\r
45 User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Sat, 17 Dec 2011 18:40:30 +0400
\r
48 Message-ID: <87ty4zw9b5.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sat, 17 Dec 2011 14:41:17 -0000
\r
65 On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
\r
66 > From the emacs changelog:
\r
68 > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
\r
69 > passes it to the mail user agent function. This argument specifies an
\r
70 > action for returning to the caller after finishing with the mail.
\r
71 > This is currently used by Rmail to delete a mail window.
\r
73 > Under Emacs 24, notmuch breaks when this argument is passed to it by a
\r
74 > function in another part of Emacs. One example of a functon that does
\r
75 > this is report-emacs-bug -- so notmuch users cannot file emacs bug
\r
78 > This patch also adds a &rest argument to the arg-list of this function,
\r
79 > to future-proof against such changes. This is adapted from the approach
\r
80 > taken by message-mail, a similar function built into emacs.
\r
82 > This patch was originally submitted by richardmurri@gmail.com on Aug. 1:
\r
83 > id:"877h6x6oor.fsf@veracitynetworks.com"
\r
86 > This version of the patch adopts Dmitry's arg-passing approach, and also
\r
87 > cleans up a long line (it is still slightly over 80 chars as I didn't
\r
88 > see a better way to break it). Tomi, I don't see two interactive calls
\r
89 > -- I think Emacs would complain if this happened.
\r
92 Looks good to me, but please revert the line wrapping changes as Tomi
\r
98 > emacs/notmuch-mua.el | 15 ++++++++-------
\r
99 > 1 files changed, 8 insertions(+), 7 deletions(-)
\r
101 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
102 > index 8824b08..510c951 100644
\r
103 > --- a/emacs/notmuch-mua.el
\r
104 > +++ b/emacs/notmuch-mua.el
\r
105 > @@ -124,9 +124,10 @@ list."
\r
107 > (message-goto-to))
\r
109 > -(defun notmuch-mua-mail (&optional to subject other-headers continue
\r
110 > - switch-function yank-action send-actions)
\r
111 > - "Invoke the notmuch mail composition window."
\r
112 > +(defun notmuch-mua-mail (&optional to subject other-headers &rest other-args)
\r
113 > + "Invoke the notmuch mail composition window.
\r
115 > +OTHER-ARGS are passed through to `message-mail'."
\r
118 > (when notmuch-mua-user-agent-function
\r
119 > @@ -135,11 +136,11 @@ list."
\r
120 > (push (cons "User-Agent" user-agent) other-headers))))
\r
122 > (unless (mail-header 'from other-headers)
\r
123 > - (push (cons "From" (concat
\r
124 > - (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
\r
125 > + (push (cons "From"
\r
126 > + (concat (notmuch-user-name) " <" (notmuch-user-primary-email) ">"))
\r
127 > + other-headers))
\r
129 > - (message-mail to subject other-headers continue
\r
130 > - switch-function yank-action send-actions)
\r
131 > + (apply #'message-mail to subject other-headers other-args)
\r
132 > (message-sort-headers)
\r
133 > (message-hide-headers)
\r
134 > (set-buffer-modified-p nil)
\r
138 > _______________________________________________
\r
139 > notmuch mailing list
\r
140 > notmuch@notmuchmail.org
\r
141 > http://notmuchmail.org/mailman/listinfo/notmuch
\r