c5/63e96805f33f2dc1723930b0f1776a4b3bf15d

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 18CB5431FC2\r
   6         for <notmuch@notmuchmail.org>; Thu, 13 Jun 2013 09:20:31 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id ZJdsOatj3PFT for <notmuch@notmuchmail.org>;\r
  16         Thu, 13 Jun 2013 09:20:21 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 3F47F431FBC\r
  20         for <notmuch@notmuchmail.org>; Thu, 13 Jun 2013 09:20:21 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7fa26d000004bab-5e-51b9f1434ab8\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 5F.A2.19371.341F9B15; Thu, 13 Jun 2013 12:20:19 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5DGKHUY001390; \r
  27         Thu, 13 Jun 2013 12:20:18 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5DGKFKC002758\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Thu, 13 Jun 2013 12:20:17 -0400\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1UnAFz-00075b-1o; Thu, 13 Jun 2013 12:20:15 -0400\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  39 Subject: Re: [RFC PATCH] revert: Removed top level --stderr= option\r
  40 In-Reply-To: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi>\r
  41 References: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi>\r
  42 User-Agent: Notmuch/0.15.2+174~g8d6aa60 (http://notmuchmail.org) Emacs/23.4.1\r
  43         (i486-pc-linux-gnu)\r
  44 Date: Thu, 13 Jun 2013 12:20:14 -0400\r
  45 Message-ID: <87hah20ypt.fsf@awakening.csail.mit.edu>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixCmqrev8cWegwZrtohbXb85ktnizch6r\r
  50         A5PH4a8LWTyerbrFHMAUxWWTkpqTWZZapG+XwJWx6t5D5oIDnBUT/7SxNzBeY+9i5OSQEDCR\r
  51         uPr7NCuELSZx4d56ti5GLg4hgX2MEnc+nWeGcDYySpy7+IoVwjnNJLHtei8LhLOEUWJC+zKw\r
  52         WWwCGhLb9i9nBLFFBGwlriw5CdTBwcEMNLd9XghIWFjAWeLpzpXMIDYnkL164zWw1UICThJN\r
  53         E8+AtYoKJEqcbL3MDtLKIqAq8fQPWCsv0KXvfy5nhbAFJU7OfMICYjMLaEnc+PeSaQKj4Cwk\r
  54         qVlIUgsYmVYxyqbkVunmJmbmFKcm6xYnJ+blpRbpGunlZpbopaaUbmIEB6ok7w7GdweVDjEK\r
  55         cDAq8fBynNsZKMSaWFZcmXuIUZKDSUmUd9EHoBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3r5X\r
  56         QDnelMTKqtSifJiUNAeLkjiv6C2glEB6YklqdmpqQWoRTFaGg0NJgtcPZKhgUWp6akVaZk4J\r
  57         QpqJgxNkOA/QcF2QGt7igsTc4sx0iPwpRkUpcV4tkIQASCKjNA+uF5ZIXjGKA70izOsKUsUD\r
  58         TEJw3a+ABjMBDS7K2A4yuCQRISXVwOiVd3qShM5Lx1d+d5iN96m2Ghcey/p87cj31loP52e2\r
  59         Kyy/vVnaFBixsz5n7+1KxueSau82cM9/2jCjPcjQfFehXb6l72KxeJkrvByX134KvbFx26FS\r
  60         E1cnzr+eP79cOHbgqnvU+2vJ6l8yy87I5NYZHPx/omhd5PaDk1eINcQfFX+qdOKwp5gSS3FG\r
  61         oqEWc1FxIgDfOmaR/wIAAA==\r
  62 Cc: tomi.ollila@iki.fi\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Thu, 13 Jun 2013 16:20:31 -0000\r
  76 \r
  77 LGTM.  While I thought --stderr was a fine solution originally, now that\r
  78 we've stumbled across problems that make it difficult to use correctly\r
  79 and robustly, I think Tomi's right that we should probably revert it.\r
  80 \r
  81 On Fri, 31 May 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
  82 > While looked good on paper, its attempted use caused confusion, complexity,\r
  83 > and potential for information leak when passed through wrapper scripts.\r
  84 > For slimmer code and to lessen demand for maintenance/support the set of\r
  85 > commits which added top level --stderr= option is now reverted.\r
  86 > ---\r
  87 >\r
  88 > Change was easy, commit message hard. Opinions? Revert is easiest to do now.\r
  89 > Also, if someone comes with a novel idea how to utilize --stderr option\r
  90 > please tell it now -- I'd be most eager to hear it :D\r
  91 >\r
  92 >\r
  93 > This change was done the following way:\r
  94 >\r
  95 > $ git checkout -b rvrt b9020448bd\r
  96 > $ git reset --hard HEAD^^^^\r
  97 > $ git reset b9020448bd\r
  98 > $ git commit -a\r
  99 > $ git diff HEAD~5..HEAD\r
 100 >\r
 101 > (last one to reveal HEAD~5 & HEAD have identical trees).\r
 102 >\r
 103 > Question why:\r
 104 > id:20130521195549.6550.53636@thinkbox.jade-hamburg.de\r
 105 >\r
 106 > Good reason why not:\r
 107 > id:1369934016-22308-1-git-send-email-amdragon@mit.edu\r