1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C5D26431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 23:07:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id aYOfwdBOQnYS for <notmuch@notmuchmail.org>;
\r
16 Tue, 21 Aug 2012 23:07:06 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id B50D6431FAE
\r
19 for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 23:07:06 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 2B332100386; Wed, 22 Aug 2012 09:07:14 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Ben Gamari <bgamari.foss@gmail.com>, notmuch <notmuch@notmuchmail.org>
\r
24 Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact
\r
25 In-Reply-To: <87y5l8z4dw.fsf@gmail.com>
\r
26 References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>
\r
27 <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com>
\r
28 <m27gssitot.fsf@guru.guru-group.fi> <87y5l8z4dw.fsf@gmail.com>
\r
29 User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1
\r
30 (x86_64-redhat-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 22 Aug 2012 09:07:14 +0300
\r
35 Message-ID: <m2txvv794d.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 22 Aug 2012 06:07:11 -0000
\r
52 On Tue, Aug 21 2012, Ben Gamari wrote:
\r
54 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
56 >> On Mon, Aug 20 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
\r
59 >> Hmm, I guess the check above is to determine whether xapian version is
\r
60 >> 1.2.6 or newer, but is there xapian version 1.1.6 or 1.0.6 or 0.3.0 or so ?
\r
62 > Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the
\r
67 >>> if [ "${xapian_major_version}" -gt 1 ] ||
\r
68 >>> [ ${xapian_minor_version} -gt 2 ] ||
\r
69 >>> [ ${xapian_subminor_version} -ge 6 ]; then
\r
71 would match e.g. 1.1.6, 1.0.6 and 0.3.0
\r
73 Presuming that those variables are always numeric the comparison could be:
\r
75 if [ ${xapian_major_version} -gt 1 ] ||
\r
76 [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] ||
\r
77 [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \
\r
78 ${xapian_subminor_version} -ge 6 ]; then
\r
80 (I could not figure out anything shorter and/or cleaner)
\r