1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 19CD2431FC2
\r
6 for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 00:13:49 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id On3siqpaOiqB for <notmuch@notmuchmail.org>;
\r
16 Fri, 25 Oct 2013 00:13:40 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 89E91431FB6
\r
19 for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 00:13:40 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 96108100217;
\r
22 Fri, 25 Oct 2013 10:13:32 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: Add a space after completed tag operations
\r
26 In-Reply-To: <1382650227-4055-1-git-send-email-amdragon@mit.edu>
\r
27 References: <1382650227-4055-1-git-send-email-amdragon@mit.edu>
\r
28 User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Fri, 25 Oct 2013 10:13:32 +0300
\r
34 Message-ID: <m2bo2desbn.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Fri, 25 Oct 2013 07:13:49 -0000
\r
51 On Fri, Oct 25 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
53 > Previously, when a user fully completed a tag operation, they had to
\r
54 > press space to begin entering another tag operation. This is
\r
55 > different from, say, shell file name completion, which typically
\r
56 > inserts a space after an unambiguous completion under the assumption
\r
57 > that the user will want to enter more input.
\r
59 > This patch tweaks `notmuch-read-tag-changes' to act more like shell
\r
60 > file name completion: after an unambiguous tag completion, it now
\r
61 > inserts a space, ready and waiting for another tagging operation from
\r
62 > the user. This is backwards-compatible with old habits, since there's
\r
63 > no harm in putting an extra space.
\r
66 LGTM. Tested by hand-editing "(mapcar ...)" part to the code (re-evaluated
\r
67 defun in *scratch* buffer) and it worked fine.
\r
73 > Just because of the context, this must be applied on top of the
\r
74 > currently pending tag completion series
\r
75 > id:"1382487721-31776-1-git-send-email-amdragon@mit.edu". The change
\r
76 > itself should be otherwise independent.
\r
78 > emacs/notmuch-tag.el | 12 ++++++++++--
\r
79 > 1 file changed, 10 insertions(+), 2 deletions(-)
\r
81 > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
\r
82 > index 7b21006..8b921f1 100644
\r
83 > --- a/emacs/notmuch-tag.el
\r
84 > +++ b/emacs/notmuch-tag.el
\r
85 > @@ -229,8 +229,16 @@ initial input in the minibuffer."
\r
86 > (set-keymap-parent map crm-local-completion-map)
\r
87 > (define-key map " " 'self-insert-command)
\r
89 > - (delete "" (completing-read-multiple prompt
\r
90 > - tag-list nil nil initial-input
\r
91 > + (delete "" (completing-read-multiple
\r
93 > + ;; Append the separator to each completion so when the
\r
94 > + ;; user completes a tag they can immediately begin
\r
95 > + ;; entering another. `completing-read-multiple'
\r
96 > + ;; ultimately splits the input on crm-separator, so we
\r
97 > + ;; don't need to strip this back off (we just need to
\r
98 > + ;; delete "empty" entries caused by trailing spaces).
\r
99 > + (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list)
\r
100 > + nil nil initial-input
\r
101 > 'notmuch-read-tag-changes-history))))
\r
103 > (defun notmuch-update-tags (tags tag-changes)
\r
107 > _______________________________________________
\r
108 > notmuch mailing list
\r
109 > notmuch@notmuchmail.org
\r
110 > http://notmuchmail.org/mailman/listinfo/notmuch
\r