1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 332D4431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:20:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id aM4Sl5pbkAN8 for <notmuch@notmuchmail.org>;
\r
16 Tue, 22 Oct 2013 17:19:57 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id A9758431FAE
\r
20 for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:19:57 -0700 (PDT)
\r
21 X-AuditID: 12074422-b7f5a8e000000a34-77-5267162cd29d
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id DF.B5.02612.C2617625; Tue, 22 Oct 2013 20:19:56 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r9N0JtIp013499;
\r
27 Tue, 22 Oct 2013 20:19:56 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9N0Jri0005132
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Tue, 22 Oct 2013 20:19:54 -0400
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1VYmAy-0000oG-SP; Tue, 22 Oct 2013 20:19:52 -0400
\r
37 Date: Tue, 22 Oct 2013 20:19:52 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH 0/8] Improve tag change completion
\r
41 Message-ID: <20131023001952.GD20337@mit.edu>
\r
42 References: <1382471457-26056-1-git-send-email-amdragon@mit.edu>
\r
43 <87mwm1x9pi.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <87mwm1x9pi.fsf@qmul.ac.uk>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT0dURSw8yWPjTymL1XB6L6zdnMjsw
\r
51 eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGQeeL2ctWCdR8W7hLvYGxrXCXYycHBICJhLN
\r
52 r56xQdhiEhfurQezhQT2MUqs+lXVxcgFZG9klPjwvokRwjnNJHG/t4kdwlnCKPGj7xYLSAuL
\r
53 gKrEr9dzmEFsNgENiW37lzOC2CICOhK3Dy1gB7GZBaQlvv1uZgKxhQXMJCY+7GcFsXmBaiYc
\r
54 nwMU5wAaGifReF4PIiwocXLmExaIVi2JG/9egpWAjFn+jwMkzAm06eHxDrBNogIqElNObmOb
\r
55 wCg0C0n3LCTdsxC6FzAyr2KUTcmt0s1NzMwpTk3WLU5OzMtLLdI11cvNLNFLTSndxAgOaRel
\r
56 HYw/DyodYhTgYFTi4X3QkhYkxJpYVlyZe4hRkoNJSZRXnT89SIgvKT+lMiOxOCO+qDQntfgQ
\r
57 owQHs5IIb7MvUDlvSmJlVWpRPkxKmoNFSZz3Fod9kJBAemJJanZqakFqEUxWhoNDSYJXTBRo
\r
58 qGBRanpqRVpmTglCmomDE2Q4D9BwY5Aa3uKCxNzizHSI/ClGRSlx3psiQAkBkERGaR5cLyzl
\r
59 vGIUB3pFmPcLSBUPMF3Bdb8CGswENHjKEpCri0sSEVJSDYzZUXrvM4LUklZ4910u69/ZdOPt
\r
60 9qR5OQcUnE82MsZ/v8sk+V+X1WB1eH/Tn33TxDK82hSZGqO9NnR3RG2oT3faqGj2VLeq9cgV
\r
61 18Ov9ZTfBN2wiPxVUXwyu/uR0A3b5Gd717zbfvL4hu5Nq+QPf+hYWfbDfPI7d8O08PBfWd9y
\r
62 lGTeVHyYc1eJpTgj0VCLuag4EQDI3bfwFAMAAA==
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Wed, 23 Oct 2013 00:20:05 -0000
\r
78 Quoth Mark Walters on Oct 22 at 10:43 pm:
\r
79 > This looks good to me +1. It makes the code clearer and nicer to read as
\r
80 > well as giving a better user experience, and it is makes fixing the long
\r
81 > standing tagging races simpler.
\r
83 > I have a couple of docstring comments:
\r
85 > In patch 2 perhaps notmuch-tag-completions could have a docstring.
\r
87 Added. I noticed that I had failed to update the call from
\r
88 `notmuch-select-tag-with-completion', so I fixed that, too. I don't
\r
89 understand why we take lists of search terms in random places and
\r
90 never use more than one element, but I suppose this series doesn't
\r
91 make that any worse.
\r
93 > In Patch 4 I think the docstring for notmuch-search-tag is outdated: it
\r
94 > is "Change tags for the currently selected thread or region." but
\r
95 > beg and end can now be specified by the caller.
\r
97 I've left the first sentence as it is, since it's good interactive
\r
98 documentation and a typical way to describe functions even if they
\r
99 take a region as arguments (see, for example, `kill-region'). But
\r
100 I've elaborated the rest of the docstring to be clearer about this.
\r
102 > and one actual comment:
\r
104 > in patch 3 (for show) delete-dups is called before the list is passed to
\r
105 > notmuch-read-tag-changes whereas it is not for search or pick.
\r
106 > Obviously this is not actually a problem but it might be worth being
\r
109 Ah, whoops. I'd done this before I decided to handle duplicates in
\r
110 `notmuch-read-tag-changes'. Since it's redundant, I've removed it.
\r
112 > But that was all I found. All tests pass and everything I try behaves
\r
113 > exactly as expected.
\r
120 > On Tue, 22 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
121 > > This series improves tag change completion in various ways for
\r
122 > > commands like +, -, and *.
\r
124 > > From a user perspective, this provides command-specific prompts like
\r
125 > > "Tag message" and "Tag all" instead of the generic "Tag" prompt, and
\r
126 > > bases tag removal completions on the tags that are in the buffer,
\r
127 > > rather than the current tags in the database, providing a more
\r
128 > > predicable experience.
\r
130 > > From an implementation perspective, this new tag removal completion
\r
131 > > behavior improves efficiency and eliminates a road block to fixing the
\r
132 > > tagging race bug (which otherwise results in massive queries just to
\r
133 > > compute removal completions). The new code is also more "Elispy" and
\r
134 > > predictable because all tag change prompting now occurs at the
\r
135 > > interactive entry points, rather than buried under several layers of
\r
136 > > non-interactive calls.
\r
138 > > This is a spiritual successor to
\r
139 > > id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though
\r
140 > > it takes a very different approach. This is also a prerequisite to
\r
141 > > the tag race fix in
\r
142 > > id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to
\r
143 > > send an updated version of that series when this one is accepted.
\r
145 > > Patches 1, 5, and 6 could be pushed on their own. They fix bugs or
\r
146 > > sort of bugs that get in the way of the rest of the series.
\r