1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 219AE431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 23 Aug 2014 08:39:19 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8BAMQf7lhpmz for <notmuch@notmuchmail.org>;
\r
16 Sat, 23 Aug 2014 08:39:15 -0700 (PDT)
\r
17 Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
\r
18 [209.85.212.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id CE5E9431FAF
\r
21 for <notmuch@notmuchmail.org>; Sat, 23 Aug 2014 08:39:14 -0700 (PDT)
\r
22 Received: by mail-wi0-f174.google.com with SMTP id d1so835698wiv.7
\r
23 for <notmuch@notmuchmail.org>; Sat, 23 Aug 2014 08:39:12 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=/3zW1AGUL9V3ardRo6nmFKWlJKhjtmZcK7Z4upt/xpk=;
\r
29 b=jAtSaq1NCkb+jfn6GP7EZ3qfjOtWQiWptz0G2z66/RzETxnDOdVvFk3AlKUjo7l7lF
\r
30 RKSRzP0z+f+u+j5AatIPHgMxm475ilTvkChfQrcQWVYevbJKtIhpPmximHeEwb24s9ba
\r
31 kWgdYMoGhT/q8HCnSTpkgEK7vZFdlts1KhE+MVzj0SDM8XO0fIMOvGZ1vmZBAiReAipk
\r
32 8VkcSL2xIjZDW6vR+e39HrNrsl1kqqnP2hPK+7R9mF/qp5zfDG80neArkD1//JdMncIP
\r
33 UCsmIVFHRXNdtVYFkjjLXm2OghRBqqh14xs1l7G1HD6yGqAsy7d9WGvbaAbimGkqTJqG
\r
36 ALoCoQlBj9A7f1P7AKlLQUi1ZkQE2ZLL9fz/7l7pedrYxTZj6QTRiHIyzsQ4SarJtVpqOTEX4LGz
\r
37 X-Received: by 10.194.77.212 with SMTP id u20mr11709191wjw.27.1408808351419;
\r
38 Sat, 23 Aug 2014 08:39:11 -0700 (PDT)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c374-75.dhcp.inet.fi.
\r
40 [88.195.116.75]) by mx.google.com with ESMTPSA id
\r
41 ay4sm10401250wib.10.2014.08.23.08.39.10 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
43 Sat, 23 Aug 2014 08:39:10 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade
\r
47 In-Reply-To: <1406859003-11561-4-git-send-email-amdragon@mit.edu>
\r
48 References: <1406859003-11561-1-git-send-email-amdragon@mit.edu>
\r
49 <1406859003-11561-4-git-send-email-amdragon@mit.edu>
\r
50 User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1
\r
51 (x86_64-pc-linux-gnu)
\r
52 Date: Sat, 23 Aug 2014 18:39:09 +0300
\r
53 Message-ID: <87siknjjvm.fsf@nikula.org>
\r
55 Content-Type: text/plain
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Sat, 23 Aug 2014 15:39:19 -0000
\r
70 On Fri, 01 Aug 2014, Austin Clements <amdragon@MIT.EDU> wrote:
\r
71 > The version number has always been pretty meaningless to the user and
\r
72 > it's about to become even more meaningless with the introduction of
\r
73 > "features". Hopefully, the database will remain on version 3 for some
\r
74 > time to come; however, the introduction of new features over time in
\r
75 > version 3 will necessitate upgrades within version 3. It would be
\r
76 > confusing if we always tell the user they've been "upgraded to version
\r
77 > 3". If the user wants to know what's new, they should read the news.
\r
79 I think this is good for now.
\r
81 What do you think about adding notmuch_database_get_features(), and
\r
89 > notmuch-new.c | 3 +--
\r
90 > test/T530-upgrade.sh | 2 +-
\r
91 > 2 files changed, 2 insertions(+), 3 deletions(-)
\r
93 > diff --git a/notmuch-new.c b/notmuch-new.c
\r
94 > index d269c7c..b7590a8 100644
\r
95 > --- a/notmuch-new.c
\r
96 > +++ b/notmuch-new.c
\r
97 > @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
\r
98 > add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,
\r
99 > &add_files_state);
\r
100 > if (add_files_state.verbosity >= VERBOSITY_NORMAL)
\r
101 > - printf ("Your notmuch database has now been upgraded to database format version %u.\n",
\r
102 > - notmuch_database_get_version (notmuch));
\r
103 > + printf ("Your notmuch database has now been upgraded.\n");
\r
106 > add_files_state.total_files = 0;
\r
107 > diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh
\r
108 > index 7d5d5aa..c4c4ac8 100755
\r
109 > --- a/test/T530-upgrade.sh
\r
110 > +++ b/test/T530-upgrade.sh
\r
111 > @@ -33,7 +33,7 @@ test_expect_equal "$output" "\
\r
112 > Welcome to a new version of notmuch! Your database will now be upgraded.
\r
113 > This process is safe to interrupt.
\r
114 > Backing up tags to FILENAME
\r
115 > -Your notmuch database has now been upgraded to database format version 2.
\r
116 > +Your notmuch database has now been upgraded.
\r
119 > test_begin_subtest "tag backup matches pre-upgrade dump"
\r
123 > _______________________________________________
\r
124 > notmuch mailing list
\r
125 > notmuch@notmuchmail.org
\r
126 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
projects / notmuch-archives.git / blob