1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B405B431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id KcIjNxhIPINw for <notmuch@notmuchmail.org>;
\r
17 Mon, 15 Oct 2012 19:15:35 -0700 (PDT)
\r
18 Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com
\r
19 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 1F933431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:35 -0700 (PDT)
\r
23 Received: by mail-qc0-f181.google.com with SMTP id x40so5261487qcp.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:34 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=Ogpn6EadXLfkrvHZwU1dw49lqo/C+AUSkl7z8wHrTUc=;
\r
29 b=BR2HPtIhi7nUQGjgu9OZrcO/H+Ss5zQBBvesrJfET3ElnYbR2fLemq+YT17Tl8zk0a
\r
30 15Bw4+GHCyem7Mp6fMmi8/zsKlw2DEM6Rp0XG+G7vbihT6qM0EL9hx+iq4RY7zPLL4Qz
\r
31 IP7fvkSTirsz1CfxmnzXvC12Efw/BqvWSflwgEZfoREVt+o6W9+KRexs34ieSsuk84o5
\r
32 Utuq/LoBgkc29LLNuLp9W4R687huXkClHVkQBa1VifY0cpG/yTNikl4ZuXIPJd8pZLKF
\r
33 FbBeFbyKgbp9G7LgaLAPO7+KOG0qJH128udNJrY5xfaVjfBwhTJJLpm9cTsAv2UcxA2F
\r
35 Received: by 10.229.38.17 with SMTP id z17mr6729659qcd.30.1350353734438;
\r
36 Mon, 15 Oct 2012 19:15:34 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id
\r
39 ig20sm14207080qab.19.2012.10.15.19.15.31
\r
40 (version=TLSv1/SSLv3 cipher=OTHER);
\r
41 Mon, 15 Oct 2012 19:15:33 -0700 (PDT)
\r
42 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
43 To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,
\r
44 Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 Subject: Re: [PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags
\r
46 of all messages in current buffer"
\r
47 In-Reply-To: <1330122640-18895-3-git-send-email-pieter@praet.org>
\r
48 References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>
\r
49 <1330122640-18895-1-git-send-email-pieter@praet.org>
\r
50 <1330122640-18895-3-git-send-email-pieter@praet.org>
\r
51 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Mon, 15 Oct 2012 22:15:30 -0400
\r
54 Message-ID: <87txtv88n1.fsf@betacantrips.com>
\r
56 Content-Type: text/plain; charset=us-ascii
\r
57 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Tue, 16 Oct 2012 02:15:35 -0000
\r
72 Pieter Praet <pieter@praet.org> writes:
\r
76 > New subtest "notmuch-show: change tags of all messages in current buffer":
\r
77 > `notmuch-show-tag-all' ("*") changes tags of *all* messages in current buffer.
\r
79 > test/emacs | 15 +++++++++++++++
\r
80 > 1 files changed, 15 insertions(+), 0 deletions(-)
\r
82 > diff --git a/test/emacs b/test/emacs
\r
83 > index ec1dbb0..d2dbafc 100755
\r
86 > @@ -136,6 +136,21 @@ test_emacs "(notmuch-show \"$os_x_darwin_thread\")
\r
87 > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
88 > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
\r
90 > +test_begin_subtest "notmuch-show: change tags of all messages in current buffer"
\r
91 > +query="$os_x_darwin_thread"
\r
92 > +filter="from:Jiang"
\r
93 > +add_tag="notmuch-show-tag-all"
\r
95 > +count_total=$(notmuch count -- "$query") # = 4
\r
96 > +count_match=$(notmuch count -- "$query" AND "$filter") # = 2
\r
98 In this test, what use is count_match? Just so that the tests' forms
\r
99 are the same? Maybe you want to put an assertion that count_total !=
\r
100 count_match, just for sanity's sake?
\r
102 Otherwise, patches 1-3 look fine to me.
\r