1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id A03BC6DE0C7E
\r
6 for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 13:02:12 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.562 tagged_above=-999 required=5 tests=[AWL=-0.090,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id V2gyhCjxCn0J for <notmuch@notmuchmail.org>;
\r
16 Fri, 12 Aug 2016 13:02:04 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id D59DA6DE0C79
\r
19 for <notmuch@notmuchmail.org>; Fri, 12 Aug 2016 13:02:03 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1A2C210007F;
\r
22 Fri, 12 Aug 2016 23:01:37 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
\r
25 David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
\r
26 Subject: Re: [PATCH v4 01/16] add util/search-path.{c,
\r
27 h} to test for executables in $PATH
\r
28 In-Reply-To: <87mvkhrfjl.fsf@alice.fifthhorseman.net>
\r
29 References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
\r
30 <1467970047-8013-2-git-send-email-dkg@fifthhorseman.net>
\r
31 <878tw2r0vf.fsf@maritornes.cs.unb.ca>
\r
32 <87k2fmse5h.fsf@alice.fifthhorseman.net>
\r
33 <87y442phbm.fsf@maritornes.cs.unb.ca>
\r
34 <87mvkhrfjl.fsf@alice.fifthhorseman.net>
\r
35 User-Agent: Notmuch/0.22+61~geeecb9e (https://notmuchmail.org) Emacs/24.5.1
\r
36 (x86_64-unknown-linux-gnu)
\r
37 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
38 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
39 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
40 Date: Fri, 12 Aug 2016 23:01:36 +0300
\r
41 Message-ID: <m2bn0xkb8f.fsf@guru.guru-group.fi>
\r
43 Content-Type: text/plain
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.20
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Fri, 12 Aug 2016 20:02:12 -0000
\r
58 On Fri, Aug 12 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
\r
60 > On Fri 2016-08-12 03:38:53 -0400, David Bremner wrote:
\r
61 >> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
\r
63 >>>> Should we distinguish between relative and absolute paths here? I can't
\r
64 >>>> think of any security implications, but I'm wondering if a relative path
\r
65 >>>> is likely just a user error.
\r
67 >>> I don't think a relative path is necessarily a user error. I certainly
\r
68 >>> use relative paths myself from time to time.
\r
70 >> As configuration values? That seems quite fragile, since it depends on
\r
71 >> the current working directory when notmuch is run.
\r
73 > rarely! but sometimes i do it because i'm testing things in strange
\r
74 > ways, and it can be a bit frustrating to have a tool second-guess me
\r
75 > when it seems like i ought to be able to drop the same string i'm using
\r
76 > on the command line into the configuration.
\r
78 > I don't feel strongly, though. if you want to say that bare words found
\r
79 > in the $PATH and absolute filenames (starting with /) are fine in the
\r
80 > notmuch config but relative paths are not, i'd be ok with that :)
\r
82 >From consistency point of view, current patch not checking it being
\r
83 absolute might prevail -- I don't see database.path being checked for
\r
86 The probability for user error is pretty small there -- if there is
\r
87 typo/thinko there things usually just starts failing. Security is
\r
88 easier to break elsewhere than here (e.g. borken PATH...)
\r
90 I'd keep the current implementation of test_for_executable()...
\r