1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CE864429E36
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:16 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id ocI8VM-rXCIo for <notmuch@notmuchmail.org>;
\r
17 Wed, 25 Jan 2012 09:36:16 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 1796D431FBC
\r
22 for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:15 -0800 (PST)
\r
23 Received: by bkbzt19 with SMTP id zt19so3689599bkb.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:14 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=XFwv70bRXYJtL1J/zrFgVY6Qkd8iRCRCE1l2n3rHZ70=;
\r
29 b=QTy5LOMnp3YeCI3i1AmsiuC+qNOwYj5oF8FuLXabOMJt6ZIlR8AuxHiGqJoEJvQinO
\r
30 210f1YluqBqjVkcqLwZcgBroDCn3fVLC2xKZQMhZWxApWj9//4QigrYwRMaugifeZ5Zn
\r
31 nyfFWBITvzjmGR6S8kuEh5dnBk/NktV3AIeuU=
\r
32 Received: by 10.205.124.11 with SMTP id gm11mr7347922bkc.68.1327512974740;
\r
33 Wed, 25 Jan 2012 09:36:14 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id bw9sm2496198bkb.8.2012.01.25.09.36.13
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 25 Jan 2012 09:36:14 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 1/4 v2] test: `visible-buffer-substring' should not return
\r
42 In-Reply-To: <1327506328-22126-2-git-send-email-dme@dme.org>
\r
43 References: <1327503908-17226-1-git-send-email-dme@dme.org>
\r
44 <1327506328-22126-1-git-send-email-dme@dme.org>
\r
45 <1327506328-22126-2-git-send-email-dme@dme.org>
\r
46 User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Wed, 25 Jan 2012 21:35:07 +0400
\r
49 Message-ID: <87sjj3heic.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Wed, 25 Jan 2012 17:36:16 -0000
\r
66 On Wed, 25 Jan 2012 15:45:25 +0000, David Edmondson <dme@dme.org> wrote:
\r
67 > When using `visible-buffer-substring' to examine a buffer, the text
\r
68 > properties are not useful, so don't include them.
\r
70 > test/test-lib.el | 2 +-
\r
71 > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
73 > diff --git a/test/test-lib.el b/test/test-lib.el
\r
74 > index bc75f06..36e793a 100644
\r
75 > --- a/test/test-lib.el
\r
76 > +++ b/test/test-lib.el
\r
77 > @@ -60,7 +60,7 @@ FILENAME is OUTPUT."
\r
78 > (while (< start end)
\r
79 > (let ((next-pos (next-char-property-change start end)))
\r
80 > (when (not (invisible-p start))
\r
81 > - (setq str (concat str (buffer-substring start next-pos))))
\r
82 > + (setq str (concat str (buffer-substring-no-properties start next-pos))))
\r
84 I would wrap this line. But would not insist :)
\r
86 Please update `visible-buffer-substring' and `visible-buffer-string'
\r
87 docstring accordingly. Smth like:
\r
89 "Same as `buffer-substring-no-properties', but excludes invisible
\r
92 "Same as `buffer-string', but excludes invisible text and text
\r
98 > (setq start next-pos)))
\r
104 > _______________________________________________
\r
105 > notmuch mailing list
\r
106 > notmuch@notmuchmail.org
\r
107 > http://notmuchmail.org/mailman/listinfo/notmuch
\r