1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 51A7B431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 5 Nov 2014 04:48:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id fBkcerrPYrCZ for <notmuch@notmuchmail.org>;
\r
17 Wed, 5 Nov 2014 04:48:45 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 3909D431FAE
\r
22 for <notmuch@notmuchmail.org>; Wed, 5 Nov 2014 04:48:45 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Xm00w-0003bf-Ql; Wed, 05 Nov 2014 12:48:43 +0000
\r
27 Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Xm00w-0001Y5-I7; Wed, 05 Nov 2014 12:48:42 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command
\r
34 In-Reply-To: <87y4rpkf8n.fsf@steelpick.2x.cz>
\r
35 References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>
\r
36 <1415058622-21162-7-git-send-email-sojkam1@fel.cvut.cz>
\r
37 <87zjc72v79.fsf@qmul.ac.uk> <87y4rqliid.fsf@steelpick.2x.cz>
\r
38 <87d291ao34.fsf@qmul.ac.uk> <87y4rpkf8n.fsf@steelpick.2x.cz>
\r
39 User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Wed, 05 Nov 2014 12:48:41 +0000
\r
42 Message-ID: <87a945ak46.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=utf-8
\r
45 Content-Transfer-Encoding: quoted-printable
\r
46 X-Sender-Host-Address: 87.81.223.162
\r
47 X-QM-Geographic: According to ripencc,
\r
48 this message was delivered by a machine in Britain (UK) (GB).
\r
49 X-QM-SPAM-Info: Sender has good ham record. :)
\r
50 X-QM-Body-MD5: 840656755c9a387761a0738326f2a88f (of first 20000 bytes)
\r
51 X-SpamAssassin-Score: -0.1
\r
52 X-SpamAssassin-SpamBar: /
\r
53 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
55 spam. We require at least 5.0 points to mark a message as spam.
\r
56 This message scored -0.1 points.
\r
57 Summary of the scoring:
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.1 AWL AWL: From: address is in the auto white-list
\r
61 X-QM-Scan-Virus: ClamAV says the message is clean
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Wed, 05 Nov 2014 12:48:50 -0000
\r
76 On Wed, 05 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
77 > On Wed, Nov 05 2014, Mark Walters wrote:
\r
78 >> On Tue, 04 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
79 >>> On Tue, Nov 04 2014, Mark Walters wrote:
\r
80 >>>> On Mon, 03 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
81 >>>>> This moves address-related functionality from search command to the
\r
82 >>>>> new address command. The implementation shares almost all code and
\r
83 >>>>> some command line options.
\r
85 >>>>> Options --offset and --limit were intentionally not included in the
\r
86 >>>>> address command, because they refer to messages numbers, which users
\r
87 >>>>> do not see in the output. This could confuse users because, for
\r
88 >>>>> example, they could see more addresses in the output that what was
\r
89 >>>>> specified with --limit. This functionality can be correctly
\r
90 >>>>> reimplemented for addresses later.
\r
92 >>>> I am not sure about this: we already have this anomaly for output=3Dfi=
\r
94 >>>> say. Also I can imagine calling notmuch address --limit=3D1000 ... to =
\r
96 >>>> a bunch of recent addresses quickly and I really am wanting to look at
\r
97 >>>> 1000 messages, not collect 1000 addresses.
\r
99 >>> I think that one of the reasons for having the new "address" command is
\r
100 >>> to have cleaner user interface. And including "anomalies" doesn't sound
\r
101 >>> like a way to achieve this. I think that now you can use "date:" query
\r
102 >>> to limit the search.
\r
104 >>> I volunteer to implement "address --limit" properly after 0.19. This
\r
105 >>> should be easy.
\r
107 >> I think this depends on how you view limit: is it to limit the output
\r
108 >> (roughly to run "head" on the output), or is to bound the amount of work
\r
109 >> notmuch has to do (eg to make sure you don't get a long delay). Your
\r
110 >> suggestion is definitely the former, whereas I am more worried about the
\r
111 >> latter: limit in your definition could take an essentially unbounded
\r
114 > Why? If I understand you correctly, you think of limit in terms of
\r
115 > messages. There is 1:N mapping between messages and addresses, where
\r
116 > N=C2=A0>=3D=C2=A01. If I limit the number of printed addresses, I limit t=
\r
118 > of messages as well. Only if N is zero (which probably can be the case
\r
119 > with Bcc and --output=3Drecipients) then it can result in unbounded work
\r
120 > (provided you have infinite number of Bcc only messages in your
\r
121 > database=C2=A0:-)).
\r
125 I was assuming the limit in your scheme would come after the
\r
126 deduplication: so notmuch would have to find "limit" distinct
\r
127 addresses. If the limit is applied before the deduping then I agree work
\r
128 is bounded (in any sane case).
\r
130 If limit is applied before the deduping then that seems fine.
\r
137 > Do I miss something?
\r