1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4E6F5429E40
\r
6 for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:24:11 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Vg2Q+4do3GfT for <notmuch@notmuchmail.org>;
\r
17 Tue, 4 Nov 2014 01:24:05 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 1992C429E3B
\r
22 for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:24:05 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1XlaL1-0002DN-Jk; Tue, 04 Nov 2014 09:24:03 +0000
\r
27 Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1XlaL1-0007Dk-4s; Tue, 04 Nov 2014 09:23:43 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v2 00/10] "notmuch address" command
\r
34 In-Reply-To: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>
\r
35 References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>
\r
36 User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Tue, 04 Nov 2014 09:23:42 +0000
\r
39 Message-ID: <87oasn2uap.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-Sender-Host-Address: 87.81.223.162
\r
43 X-QM-Geographic: According to ripencc,
\r
44 this message was delivered by a machine in Britain (UK) (GB).
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: b6037c5c405dfeacc0a4b3464d1c2425 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -0.1
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -0.1 points.
\r
53 Summary of the scoring:
\r
54 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
55 provider * (markwalters1009[at]gmail.com)
\r
56 * -0.1 AWL AWL: From: address is in the auto white-list
\r
57 X-QM-Scan-Virus: ClamAV says the message is clean
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Tue, 04 Nov 2014 09:24:11 -0000
\r
73 On Mon, 03 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
76 > this is v2 of "notmuch address" patchset. It obsoletes [1].
\r
78 > Don't be scared by the number of patches. Most of them are trivial
\r
79 > refactoring. Patches 1-4 refactor the code so that "notmuch search"
\r
80 > command is easier to split. Patch 5 is Jani's hierarchical command
\r
81 > line parsing patch. Patch 6 splits search functionality to new address
\r
82 > command. Patch 7 is minor refactoring. Patches 8-10 correspond to
\r
83 > patches 5-7 in the original "notmuch search
\r
84 > --output=sender/recipients" patch series [2].
\r
88 > - Rebased to current master (conflicted with Jani's "notmuch search
\r
89 > --duplicate=N with --output=messages" patch)
\r
90 > - Fixed printing of false "Unrecognized option" error message in
\r
91 > hierarchical command line parser.
\r
93 Overall this series looks good. My inclination is to leave patch 10
\r
94 until after the freeze but I am happy either way. Tests all work and my
\r
97 A couple of other comments:
\r
99 you should add something to devel/schemata detailing the fields in the
\r
100 structured address output.
\r
102 Please check the new manpage: I think some of it is slightly outdated. I
\r
103 mentioned in my comments the exclude=false, but missed exclude=all. Also
\r
104 the manpage could say what actually gets printed in the default text
\r
105 case (in particular to emphasise that it includes the real name)
\r
116 > [1] id:1414889400-30977-1-git-send-email-sojkam1@fel.cvut.cz
\r
117 > [2] id:1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz
\r
121 > cli: add support for hierarchical command line option arrays
\r
123 > Michal Sojka (9):
\r
124 > cli: search: Rename options to context
\r
125 > cli: search: Move more variables into search_context_t
\r
126 > cli: search: Convert ctx. to ctx->
\r
127 > cli: search: Split notmuch_search_command to smaller functions
\r
128 > cli: Introduce "notmuch address" command
\r
129 > cli: search: Convert --output to keyword argument
\r
130 > cli: address: Do not output duplicate addresses
\r
131 > cli: address: Add --output=count
\r
132 > cli: address: Add --filter-by option to configure address filtering
\r
134 > command-line-arguments.c | 16 +-
\r
135 > command-line-arguments.h | 1 +
\r
136 > completion/notmuch-completion.bash | 48 +++-
\r
137 > completion/notmuch-completion.zsh | 11 +-
\r
138 > doc/man1/notmuch-address.rst | 140 ++++++++++++
\r
139 > doc/man1/notmuch-search.rst | 21 +-
\r
140 > doc/man1/notmuch.rst | 7 +-
\r
141 > notmuch-client.h | 3 +
\r
142 > notmuch-search.c | 454 +++++++++++++++++++++++++------------
\r
144 > test/T095-address.sh | 148 ++++++++++++
\r
145 > test/T097-address-filter-by.sh | 73 ++++++
\r
146 > 12 files changed, 751 insertions(+), 173 deletions(-)
\r
147 > create mode 100644 doc/man1/notmuch-address.rst
\r
148 > create mode 100755 test/T095-address.sh
\r
149 > create mode 100755 test/T097-address-filter-by.sh
\r
154 > _______________________________________________
\r
155 > notmuch mailing list
\r
156 > notmuch@notmuchmail.org
\r
157 > http://notmuchmail.org/mailman/listinfo/notmuch
\r