1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6A297431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 21 Apr 2012 11:10:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id gv3YqfzTMyUY for <notmuch@notmuchmail.org>;
\r
16 Sat, 21 Apr 2012 11:10:18 -0700 (PDT)
\r
17 Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id A14A8431FAE
\r
21 for <notmuch@notmuchmail.org>; Sat, 21 Apr 2012 11:10:17 -0700 (PDT)
\r
22 Received: by lahc1 with SMTP id c1so8318000lah.26
\r
23 for <notmuch@notmuchmail.org>; Sat, 21 Apr 2012 11:10:14 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=mime-version:sender:x-originating-ip:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :x-gm-message-state;
\r
29 bh=P7eeEiRfvJVApTuhu6BVTfFJo31L5Ph91NEeiWBBtZQ=;
\r
30 b=n4fAUCWQPaCy7uzQbNIpNfww7wdPHWzQ6ZbPylXOLcmbB2wI/DoocxxNG95f/hTogM
\r
31 1gQqy66gwbz4wTq61z+vdKsJBaMm3Rc8XtH59lCFddl0rS+RAn8mQ+P9BVgJLWQ7g6zR
\r
32 9mjkqEL6my9ZqSgAdCjrRaIhmiuqUwpv7ps3CnMOQJ5G5u005ADMhIsXbwWTjOdfxKZr
\r
33 6VhZvKJXuAQFs3yM0WcYCdaiy2niG09PEE3k0Zy0UIfR842tz8yA5REpfRmIAEF4n1pA
\r
34 fw1bzsCKm+HV7r2t2N7xYvewrkLi8D/49g6EjzWs0rFc9q6tY3An/IsyMnUpND8KPoyH
\r
37 Received: by 10.152.148.234 with SMTP id tv10mr824143lab.41.1335031814464;
\r
38 Sat, 21 Apr 2012 11:10:14 -0700 (PDT)
\r
40 Received: by 10.112.23.39 with HTTP; Sat, 21 Apr 2012 11:10:14 -0700 (PDT)
\r
41 X-Originating-IP: [96.52.216.56]
\r
42 In-Reply-To: <1334999750-21811-2-git-send-email-markwalters1009@gmail.com>
\r
43 References: <1334999750-21811-1-git-send-email-markwalters1009@gmail.com>
\r
44 <1334999750-21811-2-git-send-email-markwalters1009@gmail.com>
\r
45 Date: Sat, 21 Apr 2012 12:10:14 -0600
\r
46 X-Google-Sender-Auth: 4khZu3ep2u4JL-49XDPYmCiFwZI
\r
48 <CAMoJFUvOU1OzqPn7eCNMfECuFm+09B+YSkivTX79VTQJ6_wSjg@mail.gmail.com>
\r
49 Subject: Re: [PATCH v3 1/2] cli: make --entire-thread=false work for
\r
51 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
52 To: Mark Walters <markwalters1009@gmail.com>
\r
53 Content-Type: text/plain; charset=ISO-8859-1
\r
55 ALoCoQkjgyOOJ3hpvrO5qWPE9ayV6kZNwyoyB76Nqb2evgB+VxD29bratKrgW7RGBKX/MF8JO3we
\r
56 Cc: notmuch@notmuchmail.org
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Sat, 21 Apr 2012 18:10:18 -0000
\r
71 On Sat, Apr 21, 2012 at 03:15, Mark Walters <markwalters1009@gmail.com> wrote:
\r
72 > The --entire-thread option in notmuch-show.c defaults to true when
\r
73 > format=json. Previously there was no way to turn this off. This patch
\r
74 > makes it respect --entire-thread=false.
\r
76 > The one subtlety is that we initialise a notmuch_bool_t to -1 to
\r
77 > indicate that the option parsing has not set it. This allows the code
\r
78 > to distinguish between the option being omitted from the command line,
\r
79 > and the option being set to false on the command line.
\r
81 > Finally, all formats except Json can output empty messages for non
\r
82 > entire-thread, but in Json format we need to output {} to keep the
\r
83 > other elements (e.g. the replies to this message) in the correct
\r
86 LGTM. You can probably remove the relevant item from devel/TODO as well!
\r