1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D0AB7431FC2
\r
6 for <notmuch@notmuchmail.org>; Sun, 14 Dec 2014 01:46:48 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id UETCA3V8q4dO for <notmuch@notmuchmail.org>;
\r
16 Sun, 14 Dec 2014 01:46:45 -0800 (PST)
\r
17 Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com
\r
18 [74.125.82.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 4C358431FB6 for <notmuch@notmuchmail.org>; Sun, 14 Dec 2014 01:46:45 -0800
\r
22 Received: by mail-wg0-f42.google.com with SMTP id z12so12446263wgg.15
\r
23 for <notmuch@notmuchmail.org>; Sun, 14 Dec 2014 01:46:44 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=OLtu8CEAEpqqosmiKq6GBHdamS9eQqwoLrjLyCMCx9A=;
\r
30 b=Ky+22ZpTyXRLEuaBoMjJTQSAS43rAzDIM86N5//ENJjvn+FAxxrN7BfoAsIV2WUlLz
\r
31 MMs+ybe5i12L+8D9aX/uQ3vOxsI1JCbAxxDz3wu61E634zADJV/dt00wVjgnVJr8YZ3S
\r
32 FheqBM003X7uhgJrO2JV4vdzktATJoQcyhwZBCvJ8whZm6ULqR+mojz4wjcOgUDV6h3P
\r
33 y1KRgmcE8Pus4t8eE621LjLd2UqH4ohqA2pQWe52Q5hP+X9dNzhv4SEAkhrRcwNHEkew
\r
34 k0ynQVBgcOqlLxGbSmB4fOhUW0jWcGjx/WncmDBcEn+j30VbDQMr+I86Fih/+MYKfCSN
\r
37 ALoCoQkEiO3ChZSpwwBYFuSfR79kfmvgAQm6TJDKzuc+RzZSePqJgynnUfqNENtuItlD5TE77UT8
\r
38 X-Received: by 10.194.48.109 with SMTP id k13mr43426136wjn.7.1418550404131;
\r
39 Sun, 14 Dec 2014 01:46:44 -0800 (PST)
\r
40 Received: from localhost (dsl-hkibrasgw2-58c37d-174.dhcp.inet.fi.
\r
42 by mx.google.com with ESMTPSA id f7sm8771928wiz.13.2014.12.14.01.46.43
\r
43 for <multiple recipients>
\r
44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
45 Sun, 14 Dec 2014 01:46:43 -0800 (PST)
\r
46 From: Jani Nikula <jani@nikula.org>
\r
47 To: Lukasz Stelmach <stlman@poczta.fm>, notmuch@notmuchmail.org
\r
48 Subject: Re: [PATCH] emacs: do not change users' mail agent configuration
\r
49 In-Reply-To: <548CB582.4040807@poczta.fm>
\r
50 References: <1418410466-26604-1-git-send-email-stlman@poczta.fm>
\r
51 <87k31vqn1h.fsf@nikula.org> <548CB582.4040807@poczta.fm>
\r
52 User-Agent: Notmuch/0.19+3~g7585e8c (http://notmuchmail.org) Emacs/24.4.1
\r
53 (x86_64-pc-linux-gnu)
\r
54 Date: Sun, 14 Dec 2014 11:46:48 +0200
\r
55 Message-ID: <87h9wyr2bb.fsf@nikula.org>
\r
57 Content-Type: text/plain; charset=utf-8
\r
58 Content-Transfer-Encoding: quoted-printable
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sun, 14 Dec 2014 09:46:49 -0000
\r
73 On Sat, 13 Dec 2014, Lukasz Stelmach <stlman@poczta.fm> wrote:
\r
74 > On 13.12.2014 22:04, Jani Nikula wrote:
\r
75 >> On Fri, 12 Dec 2014, =C5=81ukasz Stelmach <stlman@poczta.fm> wrote:
\r
76 >>> `mail-user-agent' is defined with defcustom and may be customised
\r
77 >>> by users. It should not be set to arbitrary values in modules.
\r
81 >>> To make use of that configuration value call `compose-mail' which
\r
82 >>> starts user's preferred mail composition package as selected with
\r
83 >>> the variable `mail-user-agent' instead of notmuch's hardcoded
\r
86 >> So your proposed change is that `notmuch-mua-mail` should start
\r
87 >> whichever mua the user has configured in `mail-user-agent` instead of
\r
88 >> the notmuch mail composition window, as described in the function
\r
89 >> documentation? I don't think I like that either.
\r
91 >> Maybe we should let bind `mail-user-agent` instead?
\r
94 > Actually `message-mail` isn't a "notmuch mail composition window" but
\r
95 > rather a "mail composition window" implemented in message.el which is a
\r
96 > part of Emacs. Even more, it is the default "mail composition window"
\r
97 > in Emacs because the default value of `mail-user-agent`, as defined in
\r
98 > simple.el, is `message-user-agent` (since Emacs 23.3 as described in a
\r
99 > comment in `compose-mail` function therein) which causes to be launched by
\r
102 Basically notmuch layers its own stuff on top of message mode.
\r
104 > TL;DR with the mail-user-agent variable set to the default value nothing
\r
105 > changes for a notmuch user.
\r
107 Except `message-user-agent` gets used instead of `notmuch-user-agent`
\r
108 which does the layering on top. We currently don't do much more, but
\r
109 might in the future. As an example, `notmuch-mua-send-hook` won't get
\r
112 Another question open to debate is, if the user is using the notmuch
\r
113 interface, and calls a function named `notmuch-mua-new-mail` to compose
\r
114 mail, should the function respect `mail-user-agent` and pop up a
\r
115 non-notmuch interface? Basically what we do is tested to work on top of
\r
116 message mode only, so all bets would be off anyway.
\r
124 >>> NEWS | 10 ++++++++++
\r
125 >>> emacs/notmuch-mua.el | 2 +-
\r
126 >>> emacs/notmuch.el | 2 --
\r
127 >>> 3 files changed, 11 insertions(+), 3 deletions(-)
\r
129 >>> diff --git a/NEWS b/NEWS
\r
130 >>> index 44e8d05..cf5b3c3 100644
\r
133 >>> @@ -64,6 +64,16 @@ Added `notmuch address` subcommand
\r
134 >>> Emacs Interface
\r
135 >>> ---------------
\r
137 >>> +Fixed `mail-user-agent` handling
\r
139 >>> + The value of the mail-user-agent variable is not forcibly set to
\r
140 >>> + `notmuch-user-agent`, regardles of how a user has customised it,
\r
141 >>> + everytime notmuch.el is loaded. This way, someone who used for examp=
\r
143 >>> + Gnus has her MUA and notmuch just as a search engine, doesn't have h=
\r
145 >>> + configuration broken everytime notmuch.el is loaded. The user can now
\r
146 >>> + use her favourite mail composing package when replying messages in
\r
149 >> I understand you're annoyed at the current behaviour, but please don't
\r
150 >> pour that annoyance into notmuch NEWS. Thank you.
\r
152 > It wasn't my intention. I wasn't even sure I should add to NEWS anything
\r
153 > at all but the "Contributing" page says to update NEWS if a change is
\r
154 > user visible. Considering what I wrote above, do you think it is visible?
\r
162 >>> Use the `j` key to access saved searches from anywhere in notmuch
\r
164 >>> `j` is now globally bound to `notmuch-jump`, which provides fast,
\r
165 >>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
166 >>> index 2c58886..f02c7b5 100644
\r
167 >>> --- a/emacs/notmuch-mua.el
\r
168 >>> +++ b/emacs/notmuch-mua.el
\r
169 >>> @@ -263,7 +263,7 @@ OTHER-ARGS are passed through to `message-mail'."
\r
170 >>> (push (cons 'From (concat
\r
171 >>> (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) o=
\r
174 >>> - (apply #'message-mail to subject other-headers other-args)
\r
175 >>> + (apply #'compose-mail to subject other-headers other-args)
\r
176 >>> (message-sort-headers)
\r
177 >>> (message-hide-headers)
\r
178 >>> (set-buffer-modified-p nil)
\r
179 >>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
180 >>> index 218486a..80cab57 100644
\r
181 >>> --- a/emacs/notmuch.el
\r
182 >>> +++ b/emacs/notmuch.el
\r
183 >>> @@ -1037,8 +1037,6 @@ notmuch buffers exist, run `notmuch'."
\r
184 >>> (switch-to-buffer first))
\r
187 >>> -(setq mail-user-agent 'notmuch-user-agent)
\r
189 >>> (provide 'notmuch)
\r
191 >>> ;; After provide to avoid loops if notmuch was require'd via notmuch-i=
\r
196 >>> _______________________________________________
\r
197 >>> notmuch mailing list
\r
198 >>> notmuch@notmuchmail.org
\r
199 >>> http://notmuchmail.org/mailman/listinfo/notmuch
\r
204 > By=C5=82o mi bardzo mi=C5=82o. Twoje oczy lubi=C4=85 mn=
\r
206 >>=C5=81ukasz< i to mnie zgubi (c)SNL
\r
208 > REKLAMA: http://ars-fabrica.eu/ sklep z r=C4=99kodzie=C5=82em
\r