1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DFF19431FD0
\r
6 for <notmuch@notmuchmail.org>; Tue, 25 Jan 2011 00:41:46 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2aEFHQ7A+1O7 for <notmuch@notmuchmail.org>;
\r
16 Tue, 25 Jan 2011 00:41:45 -0800 (PST)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id C2392431FB6
\r
19 for <notmuch@notmuchmail.org>; Tue, 25 Jan 2011 00:41:45 -0800 (PST)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 857DB19F3300;
\r
22 Tue, 25 Jan 2011 09:41:44 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id 7LsLsPmMlUgd; Tue, 25 Jan 2011 09:41:43 +0100 (CET)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 2DE2B19F32F7;
\r
30 Tue, 25 Jan 2011 09:41:43 +0100 (CET)
\r
31 Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id 2B81715C031;
\r
34 Tue, 25 Jan 2011 09:41:43 +0100 (CET)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.72)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1PheT8-0004Zw-Qh; Tue, 25 Jan 2011 09:41:42 +0100
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Jameson Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 1/4] Import date/time parser from GNU coreutils
\r
41 In-Reply-To: <87ei82uh8h.fsf@servo.finestructure.net>
\r
42 References: <1295783247-21900-1-git-send-email-sojkam1@fel.cvut.cz>
\r
43 <1295783247-21900-2-git-send-email-sojkam1@fel.cvut.cz>
\r
44 <87ei82uh8h.fsf@servo.finestructure.net>
\r
45 User-Agent: Notmuch/0.5-87-g9705d00 (http://notmuchmail.org) Emacs/23.2.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Tue, 25 Jan 2011 09:41:42 +0100
\r
48 Message-ID: <87r5c1iddl.fsf@steelpick.2x.cz>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Tue, 25 Jan 2011 08:41:47 -0000
\r
65 On Mon, 24 Jan 2011, Jameson Rollins wrote:
\r
66 > On Sun, 23 Jan 2011 12:47:24 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
67 > > This function have quite a lot dependencies. We may reduce them later it
\r
68 > > it is a problem.
\r
70 > > lib/c-ctype.c | 398 +++++++
\r
71 > > lib/c-ctype.h | 297 +++++
\r
72 > > lib/getdate.c | 3497 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
\r
73 > > lib/getdate.h | 22 +
\r
74 > > lib/getdate.y | 1572 +++++++++++++++++++++++++
\r
75 > > lib/gettime.c | 48 +
\r
76 > > lib/intprops.h | 83 ++
\r
77 > > lib/timespec.h | 39 +
\r
78 > > lib/verify.h | 140 +++
\r
79 > > 9 files changed, 6096 insertions(+), 0 deletions(-)
\r
80 > > create mode 100644 lib/c-ctype.c
\r
81 > > create mode 100644 lib/c-ctype.h
\r
82 > > create mode 100644 lib/getdate.c
\r
83 > > create mode 100644 lib/getdate.h
\r
84 > > create mode 100644 lib/getdate.y
\r
85 > > create mode 100644 lib/gettime.c
\r
86 > > create mode 100644 lib/gettime.h
\r
87 > > create mode 100644 lib/intprops.h
\r
88 > > create mode 100644 lib/timespec.h
\r
89 > > create mode 100644 lib/verify.h
\r
91 > Hi, Michal. I don't fully understand what's going on here, but it seems
\r
92 > like you're embedding code copies from somewhere else. If that's the
\r
93 > case, is there a reason that we would need to do that, rather than just
\r
94 > linking against an external library?
\r
96 Well, if the embedded code is available in a library, it would be
\r
97 definitely better to just use the library. But the above code is
\r
98 statically linked to things like `date` command and is not available
\r
101 Most of the dependencies could be eliminated since they usually
\r
102 replicate functionality which is available in modern C library and are
\r
103 there only for compatibility reasons.
\r
105 On the other hand, if anybody knows a better date parser, perhaps in a
\r
106 separate library, let me know.
\r