b8/374716a2c5b8bb0c7bb174d4bc667ab2885505

   1 Return-Path: <jrollins@finestructure.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1B604431FD0\r
   6         for <notmuch@notmuchmail.org>; Mon, 18 Jul 2011 12:14:39 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -2.29\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id dU-T+wgjwYOB for <notmuch@notmuchmail.org>;\r
  16         Mon, 18 Jul 2011 12:14:37 -0700 (PDT)\r
  17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
  18         [131.215.239.19])\r
  19         by olra.theworths.org (Postfix) with ESMTP id E46E3431FB6\r
  20         for <notmuch@notmuchmail.org>; Mon, 18 Jul 2011 12:14:36 -0700 (PDT)\r
  21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
  22         by fire-doxen-postvirus (Postfix) with ESMTP id 9A10E328151;\r
  23         Mon, 18 Jul 2011 12:14:36 -0700 (PDT)\r
  24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
  25 Received: from servo.finestructure.net (gwave-99.ligo.caltech.edu\r
  26         [131.215.114.99]) (Authenticated sender: jrollins)\r
  27         by fire-doxen-submit (Postfix) with ESMTP id 600113280D9;\r
  28         Mon, 18 Jul 2011 12:14:32 -0700 (PDT)\r
  29 Received: by servo.finestructure.net (Postfix, from userid 1000)\r
  30         id 4449A131; Mon, 18 Jul 2011 12:14:32 -0700 (PDT)\r
  31 From: Jameson Graef Rollins <jrollins@finestructure.net>\r
  32 To: Felix Geller <fgeller@gmail.com>, notmuch@notmuchmail.org\r
  33 Subject: Re: [PATCH 1/2] Added variable to toggle message indendation in\r
  34         Emacs' notmuch-show\r
  35 In-Reply-To: <1311015465-8136-1-git-send-email-fgeller@gmail.com>\r
  36 References: <874o2j4f1e.fsf@servo.factory.finestructure.net>\r
  37         <1311015465-8136-1-git-send-email-fgeller@gmail.com>\r
  38 User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1\r
  39         (x86_64-pc-linux-gnu)\r
  40 Date: Mon, 18 Jul 2011 12:14:29 -0700\r
  41 Message-ID: <87vcuz2yga.fsf@servo.factory.finestructure.net>\r
  42 MIME-Version: 1.0\r
  43 Content-Type: multipart/signed; boundary="=-=-=";\r
  44         micalg=pgp-sha256; protocol="application/pgp-signature"\r
  45 X-BeenThere: notmuch@notmuchmail.org\r
  46 X-Mailman-Version: 2.1.13\r
  47 Precedence: list\r
  48 List-Id: "Use and development of the notmuch mail system."\r
  49         <notmuch.notmuchmail.org>\r
  50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  51         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  53 List-Post: <mailto:notmuch@notmuchmail.org>\r
  54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  56         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  57 X-List-Received-Date: Mon, 18 Jul 2011 19:14:39 -0000\r
  58 \r
  59 --=-=-=\r
  60 \r
  61 Hi, Felix.  Thanks for resubmitting these patches.  A couple more\r
  62 comments:\r
  63 \r
  64 Remember to include a longer log message with you patch.  Beyond just\r
  65 the single line commit message, the patch should also include a longer\r
  66 commit message, separated from the first line by a blank line, that\r
  67 explains what exactly the patch is doing and why.\r
  68 \r
  69 We've also been trying to get in the habit of sending patches to the\r
  70 test suite *first*, before the patch that actually implements the\r
  71 change.  The reason being that we can apply the test-suite patch first,\r
  72 see that the feature or bug fix you're trying to implement is not\r
  73 implemented, then apply the fix and see that everything is working\r
  74 again.\r
  75 \r
  76 Now is probably a good time to remind everyone to look at the GIT patch\r
  77 submission guidlines, which notmuch has been trying to follow (also\r
  78 linked from http://notmuchmail.org):\r
  79 \r
  80 http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD\r
  81 \r
  82 jamie.\r
  83 \r
  84 --=-=-=\r
  85 Content-Type: application/pgp-signature\r
  86 \r
  87 -----BEGIN PGP SIGNATURE-----\r
  88 Version: GnuPG v1.4.11 (GNU/Linux)\r
  89 \r
  90 iQIcBAEBCAAGBQJOJIYWAAoJEO00zqvie6q8pBQQAKZxkUqPuEb6dWZZlv3Ylih6\r
  91 tSU9+yEk/ZsfcG8nOR2J5wwTES0KQEDPcMZS3ZsEZmJ52sXOzEhdLgsawQswcq0j\r
  92 HVmsUtz4j0Ar6AqBIwrm9wTUVu9uwZTogqEessv8M81anL+hEi5AkpVSnQ8kb8WZ\r
  93 Wv+ktgKe/zKVBo6DWmT1USiO7pRQ5qQGtGtw0qRWgrWbhH9p9hwaJTQB6/PzB0P7\r
  94 gVLADuPgg+xSVC0dtiJnEeJaq/m8tfPUtdD/RY67qMlyRYgAHpI3TBv6iEcV3z9v\r
  95 i98P2AYVmZDwwZEiNKMqB2iPnWo3VYDqAzKeHG6a4hMixmZT340JBr3xyNiMlZgw\r
  96 Kh/dxDB28fJr5EkGzTJEUYhzdrq3NyrxVcfTb8tf4gDx+/cmHgxq6eIczrCiCTfT\r
  97 7S/oM2rrDMb4+zE8bUcg5EQIv5b6dsCti3EQxHF3w9qntxYKa91tw9wc8Sbm+q1l\r
  98 /0UEt0L2D8YZrk8KXpzs6kZjDqmsViA6r94VTYxRZfNGOYOMNiSKjKOh+cBMBhVA\r
  99 /31yIFK1haXID70x77/KYwdOXZgjYZz5vKy0Si398tJB1JdH8ZrU3HE9B7pq6+49\r
 100 MYIZSurE7rt9tA6FmNe9IlLltgEwcNCt71yM0H/zDIvciYm0S/pJ4bKWkO3oeM6q\r
 101 OEVUsuBKPG/dFGUgqsq8\r
 102 =9ctG\r
 103 -----END PGP SIGNATURE-----\r
 104 --=-=-=--\r