1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C450F429E25
\r
6 for <notmuch@notmuchmail.org>; Fri, 8 Jul 2011 11:09:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 7MNlAcDFfucs for <notmuch@notmuchmail.org>;
\r
17 Fri, 8 Jul 2011 11:09:18 -0700 (PDT)
\r
18 Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
\r
19 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id DE8F3431FB6
\r
22 for <notmuch@notmuchmail.org>; Fri, 8 Jul 2011 11:09:17 -0700 (PDT)
\r
23 Received: by qwb7 with SMTP id 7so1221030qwb.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 08 Jul 2011 11:09:17 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=A6VqEHJNe6AAgluU5zJcJErVcy6yuSkJ+pxonyD8sKo=;
\r
30 b=I/Mtf42pxa4EsoZtICm5jzyyHIQQydqmM2K2xxK5P1Hr4aOXzgnlNNs9c07xxZdoqK
\r
31 aBm7Q5myAs2+n5RWhbsvpKyGu06R7JtRaS661HOCzccZvBfpvwp7z8vrQzgw501i7cWG
\r
32 q5C6fCChOIWuniwXwi77kwItEXHplHyUH9bSI=
\r
34 Received: by 10.229.106.32 with SMTP id v32mr1782522qco.77.1310148557060; Fri,
\r
35 08 Jul 2011 11:09:17 -0700 (PDT)
\r
36 Sender: amdragon@gmail.com
\r
37 Received: by 10.229.229.211 with HTTP; Fri, 8 Jul 2011 11:09:16 -0700 (PDT)
\r
38 In-Reply-To: <BANLkTimeWnn5YtKjarFB8f8Fowvz0PxK2Q@mail.gmail.com>
\r
39 References: <87ei34rnc5.fsf@yoom.home.cworth.org>
\r
40 <1307822683-848-1-git-send-email-amdragon@mit.edu>
\r
41 <BANLkTimeWnn5YtKjarFB8f8Fowvz0PxK2Q@mail.gmail.com>
\r
42 Date: Fri, 8 Jul 2011 14:09:16 -0400
\r
43 X-Google-Sender-Auth: dkzFpN6X4-yTEfI0GHclH7fhlVE
\r
45 <CAH-f9WvAFuVp-6u6tFgbcPEGW304wkGy=uhSOGhbNXd0m7H3mw@mail.gmail.com>
\r
46 Subject: Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues
\r
47 From: Austin Clements <amdragon@mit.edu>
\r
48 To: Carl Worth <cworth@cworth.org>
\r
49 Content-Type: text/plain; charset=ISO-8859-1
\r
50 Content-Transfer-Encoding: quoted-printable
\r
51 Cc: notmuch@notmuchmail.org
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Fri, 08 Jul 2011 18:09:19 -0000
\r
66 Rebased against current master and now atomic-new-v7 on
\r
67 http://awakening.csail.mit.edu/git/notmuch.git
\r
68 There were a handful of conflicts, but nothing substantive.
\r
70 On Wed, Jun 22, 2011 at 3:39 PM, Austin Clements <amdragon@mit.edu> wrote:
\r
73 > On Sat, Jun 11, 2011 at 4:04 PM, Austin Clements <amdragon@mit.edu> wrote=
\r
75 >> Here's the reworked patch series that uses atomic sections more
\r
76 >> heavily rather than changing the removal API. =A0This is atomic-new-v6
\r
77 >> on http://awakening.csail.mit.edu/git/notmuch.git .
\r
79 >> (I was planning to make this series on Monday while stuck on a plane,
\r
80 >> but an opportunity presented itself when I needed something better to
\r
81 >> do than fix the sink. =A0As a result, if you can look over this before
\r
82 >> Monday, I can use that time to address any further comments.)
\r
84 >> The beginning of the sequence---"test: Fix message when skipping
\r
85 >> test_expect_equal* tests" through "new: Defer updating directory
\r
86 >> mtimes until the end."---has not changed besides than the minor things
\r
87 >> you pointed out earlier. =A0Here's a quick summary of the differences in
\r
88 >> the rest of the sequence:
\r
90 >> lib: Add notmuch_database_{begin,end}_atomic.
\r
91 >> =A0Rebased but otherwise identical.
\r
93 >> lib: Add support for nested atomic sections.
\r
96 >> lib: Indicate if there are more filenames after removal.
\r
97 >> =A0Rebased but otherwise identical.
\r
99 >> lib: Remove message document directly after removing the last file
\r
101 >> =A0New. =A0Supersedes the patches that rewrote
\r
102 >> =A0notmuch_database_remove_message and made sync delete messages.
\r
104 >> lib: Add an API to find a message by filename.
\r
105 >> =A0Culled from "lib: Add API's to find by filename and ..." in the old
\r
106 >> =A0series. =A0What I kept is identical.
\r
108 >> lib: Wrap notmuch_database_add_message in an atomic section.
\r
111 >> new: Cleanup. Put removed/renamed message count in add_files_state_t.
\r
112 >> new: Cleanup. De-duplicate file name removal code.
\r
113 >> =A0Both new, but closely related to previous remove_filename patch.
\r
115 >> new: Synchronize maildir flags eagerly.
\r
116 >> =A0New, but very closely related to previous patch of the same name.
\r
117 >> =A0This patch is simpler now because of the previous two cleanups.
\r
119 >> new: Wrap adding and removing messages in atomic sections.
\r
120 >> =A0Rebased and added an atomic section around removal.
\r
122 >> lib: Improve notmuch_database_{add,remove}_message documentation.
\r
125 >> Ultimately, I still think the existing removal API is weird because it
\r
126 >> forces you to do things like lookup a message by file name just in
\r
127 >> case you need that message object after removal tells you that it
\r
128 >> didn't actually remove the message. =A0But I don't know what to do about
\r
129 >> it that isn't equally weird.
\r
131 >> _______________________________________________
\r
132 >> notmuch mailing list
\r
133 >> notmuch@notmuchmail.org
\r
134 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r