1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1D884431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 21 Feb 2012 22:46:17 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id GlJc2Hj+4oIi for <notmuch@notmuchmail.org>;
\r
16 Tue, 21 Feb 2012 22:46:16 -0800 (PST)
\r
17 Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 398D8431FAE
\r
21 for <notmuch@notmuchmail.org>; Tue, 21 Feb 2012 22:46:15 -0800 (PST)
\r
22 Received: by lahd3 with SMTP id d3so9000294lah.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 21 Feb 2012 22:46:12 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.152.102.237
\r
25 as permitted sender) client-ip=10.152.102.237;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of awg@xvx.ca designates
\r
28 10.152.102.237 as permitted sender) smtp.mail=awg@xvx.ca
\r
29 Received: from mr.google.com ([10.152.102.237])
\r
30 by 10.152.102.237 with SMTP id fr13mr21997935lab.10.1329893172980
\r
31 (num_hops = 1); Tue, 21 Feb 2012 22:46:12 -0800 (PST)
\r
33 Received: by 10.152.102.237 with SMTP id fr13mr18424909lab.10.1329893172915;
\r
34 Tue, 21 Feb 2012 22:46:12 -0800 (PST)
\r
36 Received: by 10.112.114.103 with HTTP; Tue, 21 Feb 2012 22:46:12 -0800 (PST)
\r
37 X-Originating-IP: [96.52.216.56]
\r
38 In-Reply-To: <20120217200017.GG5991@mit.edu>
\r
39 References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca>
\r
40 <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca>
\r
41 <20120217200017.GG5991@mit.edu>
\r
42 Date: Tue, 21 Feb 2012 23:46:12 -0700
\r
43 X-Google-Sender-Auth: WPQOsapDmpr1XIm2hqmD_xAGHBM
\r
45 <CAMoJFUszH+RjfOj2qpFL6ZYpG418ZtW9za56pzD7gxhp70BJFw@mail.gmail.com>
\r
46 Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and
\r
47 message-cite-original
\r
48 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
49 To: Austin Clements <amdragon@mit.edu>
\r
50 Content-Type: text/plain; charset=ISO-8859-1
\r
51 Content-Transfer-Encoding: quoted-printable
\r
53 ALoCoQlDjRefGRt6cLtC1ou4vELXCH9Uo7r45nhITIupi2PcZGBZdPe/IxnqIOphc+lai20B5H4a
\r
54 Cc: notmuch@notmuchmail.org
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Wed, 22 Feb 2012 06:46:17 -0000
\r
71 A couple of quick notes below, just before I send the new version:
\r
73 On Fri, Feb 17, 2012 at 13:00, Austin Clements <amdragon@mit.edu> wrote:
\r
74 > One of the biggest wins of using consistent JSON parsing settings is
\r
75 > that this can be replaced with notmuch-show-mm-display-part-inline,
\r
76 > which, as far as I can tell, accomplishes the same thing, but handles
\r
77 > a lot of corner-cases that this doesn't (like crypto and charset
\r
80 This would be very desirable indeed, but after taking a stab at it,
\r
81 I've discovered it's a really significant amount of work. The show
\r
82 code relies on a bunch of buffer-local variables regarding crypto and
\r
83 such, which are tricky to factor out into notmuch-lib.
\r
85 Do you think it's acceptable to leave this as future work?
\r
87 > Alternatively, notmuch-mua-get-quotable-parts could be
\r
88 > notmuch-mua-insert-quotable-parts, which would probably simplify
\r
89 > things a bit. =A0Your call.
\r
91 I've decided to leave this as get-quotable-parts. This is mostly my
\r
92 personal preference to have a single function do the insertions when
\r
93 possible, which I think makes the flow more obvious.
\r
95 > Is message-cite-original guaranteed to leave point in a reasonable
\r
96 > place for this or should we create our own marker above (probably
\r
97 > after the if re-search-backward..) and use it here to get point to the
\r
100 It turns out it actually wasn't, which is why MML tags weren't getting
\r
101 escaped twice. I've fixed this.
\r