Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[notmuch-archives.git] / b5 / a4b0ab8213218f5639f706a2d98b5402d3709c

Return-Path: <pieter@praet.org>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id 5DCF2429E25\r
        for <notmuch@notmuchmail.org>; Fri, 24 Jun 2011 13:04:20 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: -0.7\r
X-Spam-Level: \r
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
        tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id tX3faPsyxBhI for <notmuch@notmuchmail.org>;\r
        Fri, 24 Jun 2011 13:04:19 -0700 (PDT)\r
Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com\r
 [74.125.82.41])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
 CCF12431FD0    for <notmuch@notmuchmail.org>; Fri, 24 Jun 2011 13:04:18 -0700\r
 (PDT)\r
Received: by wwi14 with SMTP id 14so737662wwi.2\r
        for <notmuch@notmuchmail.org>; Fri, 24 Jun 2011 13:04:17 -0700 (PDT)\r
Received: by 10.216.68.2 with SMTP id k2mr61264wed.0.1308945857248;\r
        Fri, 24 Jun 2011 13:04:17 -0700 (PDT)\r
Received: from localhost ([109.131.122.10])\r
        by mx.google.com with ESMTPS id fr17sm2245291wbb.23.2011.06.24.13.04.15\r
        (version=TLSv1/SSLv3 cipher=OTHER);\r
        Fri, 24 Jun 2011 13:04:15 -0700 (PDT)\r
From: Pieter Praet <pieter@praet.org>\r
To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
Subject: Re: [PATCH] fix sum moar typos\r
In-Reply-To: <8762nwdtfw.fsf@yoom.home.cworth.org>\r
References: <1307202852-4398-1-git-send-email-pieter@praet.org>\r
        <1308600861-22684-1-git-send-email-pieter@praet.org>\r
        <8762nwdtfw.fsf@yoom.home.cworth.org>\r
User-Agent: Notmuch/0.5-243-g5a76944 (http://notmuchmail.org) Emacs/23.1.50.1\r
        (x86_64-pc-linux-gnu)\r
Date: Fri, 24 Jun 2011 22:04:13 +0200\r
Message-ID: <87liwrgfnm.fsf@praet.org>\r
MIME-Version: 1.0\r
Content-Type: text/plain; charset=utf-8\r
Content-Transfer-Encoding: quoted-printable\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Fri, 24 Jun 2011 20:04:20 -0000\r
\r
On Thu, 23 Jun 2011 16:22:27 -0700, Carl Worth <cworth@cworth.org> wrote:\r
Non-text part: multipart/signed\r
> On Mon, 20 Jun 2011 22:14:21 +0200, Pieter Praet <pieter@praet.org> wrote:\r
> > Various typo fixes in docs, docstrings, comments, etc...\r
> >=20\r
> > Signed-off-by: Pieter Praet <pieter@praet.org>\r
>=20\r
> Thanks for these fixes, Pieter!\r
\r
My pleasure.\r
\r
> I've pushed these all out now. I split the original commit up into 6\r
> commits that each touch different kinds of text, (non-code text files,\r
> comments within source files, error messages within source files, etc.)\r
>=20\r
> The idea there is that these different kinds of text have different\r
> potential impacts on the correctness of the code. So some release\r
> manager might be willing to include one kind of change, but not another,\r
> for example.\r
\r
Agreed.\r
\r
> Also, it made things a bit easier to read. There were two incorrect typo\r
> fixes in the original commit which I fixed:\r
>=20\r
> > -    "\tSeveral notmuch commands accept a comman syntax for search\n"\r
> > +    "\tSeveral notmuch commands accept a command syntax for search\n"\r
>=20\r
> This is now "common syntax".\r
>=20\r
> > -    # Remember stdout and stderr file descriptios and redirect test\r
> > +    # Remember stdout and stderr file descriptions and redirect test\r
>=20\r
> This is now "file descriptors".\r
>=20\r
> And one change where I left the original text unchanged:\r
>=20\r
> >   * A non-NULL return value is guaranteed to be a valid string pointer\r
> >   * pointing to the characters "new/" or "cur/", (but not\r
> > - * NUL-terminated).\r
> > + * NULL-terminated).\r
>=20\r
> This comment uses "NULL" to describe a NULL pointer and "NUL" to\r
> describe the ASCII character '\0'. (I know that "NUL" is a really\r
> annoying historically misspelled abbreviation, but it is in standard\r
> usage I believe---see ASCII(7) for example.)\r
\r
Prime examples of "or even made some new ones" [1] :D\r
\r
> Meanwhile, I was almost tempted to leave this misspelling unchanged:\r
>=20\r
> > -    (error "%s is a file. Can't creat maildir." path))\r
> > +    (error "%s is a file. Can't create maildir." path))\r
>=20\r
> Since that's also a classic historically misspelled abbreviation. ;-)\r
>=20\r
> Oh, and let me just thank you for being so thorough! There were several\r
> fixes you made that could obviously not be caught by an automated spell\r
> checker:\r
>=20\r
> > ---part=3Did", (David Edmonson wants to rewrite some of "notmuch show" =\r
to\r
> > +--part=3Did", (David Edmondson wants to rewrite some of "notmuch show"=\r
 to\r
> ...\r
> >  (defun notmuch-user-other-email ()\r
> > -  "Return the user.primary_email value (as a list) from the notmuch co=\r
nfiguration."\r
> > +  "Return the user.other_email value (as a list) from the notmuch conf=\r
iguration."\r
> ...\r
> >  (defcustom notmuch-after-tag-hook nil\r
> > -  "Hooks that are run before tags of a message are modified.\r
> > +  "Hooks that are run after tags of a message are modified.\r
> ...\r
> > -The debian packaging exists in the top-level "debian" directory within\r
> > +The Debian packaging exists in the top-level "debian" directory within\r
>=20\r
> Those all demonstrate a particular eye for detail=E2=80=94well done! For a\r
> couple of those, I almost gave them their own commits.\r
>=20\r
> In passing, let me point out the most amusing typo I saw in the patch:\r
>=20\r
> > -} /* Appleasing Emacs */\r
> > +} /* Appeasing Emacs */\r
>=20\r
> I almost hate to see that go, because I like the pleasing portmanteau\r
> sound of "appleasing". Please applease me and leave this pleasing typo?\r
>=20\r
> Admittedly, that's not in code that's originally mine, so I can't say it\r
> wasn't intentional either.\r
>=20\r
> Finally, *many* of the typos and misspellings were originally mine. It's\r
> certainly embarrassing to see so many (and so many repeats). It was also\r
> embarrassing to see how many misspellings I committed while typing the\r
> commit messages, (fortunately I rebased many away).\r
\r
Let's turn that around:\r
\r
Comments and commit messages are (understandably) a mere afterthought\r
for most coders, including myself, and are thus often very terse or\r
even nonexistent, which automatically translates to less typos (y=3Dkx).\r
\r
You however, seem to be incredibly disciplined in this respect,\r
so statistically speaking, you're destined to become typo-king,\r
and you have every reason to be *proud* of it. :D\r
\r
The only thing you could possibly have to be embarrassed about,\r
is insufficient laziness (which, for programmers, is considered a\r
virtue) ;)\r
\r
> And now I'm starting to get paranoid about this message. Am I really\r
> brave enough to type words like "embarrassing", "misspelling", and\r
> "committed" here?\r
>=20\r
> Thanks again,\r
>=20\r
> -Carl\r
Non-text part: application/pgp-signature\r
\r
\r
Peace\r
\r
--=20\r
Pieter\r
\r
\r
[1] id:"1307202852-4398-1-git-send-email-pieter@praet.org"\r