1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 8CA816DE0C51
\r
6 for <notmuch@notmuchmail.org>; Sat, 5 Sep 2015 19:37:09 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.115 tagged_above=-999 required=5 tests=[AWL=0.115]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id vBvKlrqxGOSe for <notmuch@notmuchmail.org>;
\r
16 Sat, 5 Sep 2015 19:37:06 -0700 (PDT)
\r
17 Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 7365E6DE0AC2
\r
19 for <notmuch@notmuchmail.org>; Sat, 5 Sep 2015 19:37:05 -0700 (PDT)
\r
20 Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1ZYPoX-00060k-AY; Sun, 06 Sep 2015 02:36:17 +0000
\r
23 Received: (nullmailer pid 12152 invoked by uid 1000); Sun, 06 Sep 2015
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Uli Scholler <uli@scholler.net>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH v2] emacs: wrap current search in parens when filtering
\r
28 In-Reply-To: <87io7rxj6k.fsf@tardis.scholler.priv>
\r
29 References: <1441231034-9413-1-git-send-email-uli@scholler.net>
\r
30 <m2zj142c0q.fsf@guru.guru-group.fi> <87io7rxj6k.fsf@tardis.scholler.priv>
\r
31 User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1
\r
32 (x86_64-pc-linux-gnu)
\r
33 Date: Sat, 05 Sep 2015 23:35:56 -0300
\r
34 Message-ID: <87oahgi8ab.fsf@maritornes.cs.unb.ca>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.18
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sun, 06 Sep 2015 02:37:09 -0000
\r
52 Some pretty fussy comments follow. Probably I could have fixed these in
\r
53 the time it took to write this message ;).
\r
55 Uli Scholler <uli@scholler.net> writes:
\r
56 > + (let ((grouped-query (notmuch-maybe-group-query-string query))
\r
57 > + (grouped-search-query (notmuch-maybe-group-query-string notmuch-search-query-string)))
\r
59 - I didn't find it very obvious which of these introduced variables was
\r
60 which. I thought maybe "grouped-original-query" for the second
\r
61 one. It's pretty subjective though, so your call.
\r
63 - The lines get pretty long here. We try to keep code to 80 columns.
\r
65 - Your revised patch isn't in quite the right format for git am;
\r
66 the actual commit message get's lost. The unintuitive trick is to add
\r
67 commentary in the patch after the ---
\r
69 > + (notmuch-search (if (string= grouped-search-query "*")
\r
71 > - (concat notmuch-search-query-string " and " grouped-query)) notmuch-search-oldest-first)))
\r
72 > + (concat grouped-search-query " and " grouped-query)) notmuch-search-oldest-first)))
\r