1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1F9AE431FC7
\r
6 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 02:00:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id OCE1qIamr9hA for <notmuch@notmuchmail.org>;
\r
17 Thu, 30 Oct 2014 02:00:38 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 0BEA2431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 02:00:38 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1XjlaZ-0002vG-94; Thu, 30 Oct 2014 09:00:35 +0000
\r
27 Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1XjlaY-0004TR-VY; Thu, 30 Oct 2014 09:00:15 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Tomi Ollila <tomi.ollila@iki.fi>, Michal Sojka <sojkam1@fel.cvut.cz>,
\r
33 notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to
\r
35 filter out duplicate addresses
\r
36 In-Reply-To: <m2zjceueg4.fsf@guru.guru-group.fi>
\r
37 References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
\r
38 <1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
\r
39 <87egtqug4t.fsf@qmul.ac.uk> <m2zjceueg4.fsf@guru.guru-group.fi>
\r
40 User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Thu, 30 Oct 2014 09:00:13 +0000
\r
43 Message-ID: <87r3xq9bky.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 X-Sender-Host-Address: 87.81.223.162
\r
47 X-QM-Geographic: According to ripencc,
\r
48 this message was delivered by a machine in Britain (UK) (GB).
\r
49 X-QM-SPAM-Info: Sender has good ham record. :)
\r
50 X-QM-Body-MD5: a0b2b2c2538659214970f37fd0d3d080 (of first 20000 bytes)
\r
51 X-SpamAssassin-Score: -0.1
\r
52 X-SpamAssassin-SpamBar: /
\r
53 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
55 spam. We require at least 5.0 points to mark a message as spam.
\r
56 This message scored -0.1 points.
\r
57 Summary of the scoring:
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.1 AWL AWL: From: address is in the auto white-list
\r
61 X-QM-Scan-Virus: ClamAV says the message is clean
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Thu, 30 Oct 2014 09:00:46 -0000
\r
76 On Thu, 30 Oct 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
77 > On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
79 >> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
80 >>> This adds an algorithm to filter out duplicate addresses from address
\r
81 >>> outputs (sender, receivers). The algorithm can be configured with
\r
82 >>> --filter-by command line option.
\r
84 >>> The code here is an extended version of a patch from Jani Nikula.
\r
88 >> As this is getting into the more controversial bike shedding region I
\r
89 >> wonder if it would be worth splitting this into 2 patches: the first
\r
90 >> could do the default dedupe based on name/address and the second could
\r
91 >> do add the filter-by options.
\r
93 >> I think the default deduping is obviously worth doing but I am not sure
\r
94 >> about the rest. In any case I think the default deduping could go in
\r
95 >> pre-freeze but I would recommend the rest is left until after.
\r
97 > I can agree with that, but there is one hard thing to resolve:
\r
98 > "naming things"(*)
\r
100 > (*) http://martinfowler.com/bliki/TwoHardThings.html
\r
102 > With all rest ignored (sorry no time to work on this in more detail now),
\r
103 > this default deduping could be done with single argument '--unique'...
\r
105 In this case I am suggesting that to start with the default deduping is
\r
106 unconditionally done and that there is no command line argument. We can
\r
107 decide on other filter options, possibly including a completely
\r
108 unfiltered list (*), later.
\r
114 (*) Personally I don't really see a use case for the unfiltered list but
\r
115 others may disagree.
\r