1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B2201431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 5 May 2013 02:59:00 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id WJHAzXpA9uC5 for <notmuch@notmuchmail.org>;
\r
16 Sun, 5 May 2013 02:58:56 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 81A67431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 5 May 2013 02:58:56 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 363B6100033;
\r
22 Sun, 5 May 2013 12:58:55 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Servilio Afre Puentes <servilio@gmail.com>, Jani Nikula <jani@nikula.org>,
\r
25 notmuch <notmuch@notmuchmail.org>
\r
26 Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history
\r
27 In-Reply-To: <87ppx6lo6g.fsf@goose.CSU.McMaster.CA>
\r
28 References: <87y5bwkml2.fsf@goose.CSU.McMaster.CA> <874nejrupr.fsf@nikula.org>
\r
29 <87ppx6lo6g.fsf@goose.CSU.McMaster.CA>
\r
30 User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sun, 05 May 2013 12:58:54 +0300
\r
36 Message-ID: <m2li7teoip.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 05 May 2013 09:59:00 -0000
\r
53 On Sat, May 04 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:
\r
55 > Jani Nikula <jani@nikula.org> writes:
\r
57 >> On Fri, 03 May 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:
\r
58 >>> Two patches that enhance the notmuch-hello search history UI. Though
\r
59 >>> minor I find them very helpful.
\r
61 >> Both seem to work as advertised; I did not look at the code much. A
\r
62 >> minor bikeshed is that I think y-or-n-p would suffice in patch 1/2.
\r
64 > I know, but as it clears the whole history I decided to go with a
\r
65 > confirmation that required more attention to diminish the chance of
\r
66 > accident, and the action is taken not so oftenly (at least for me, and
\r
67 > my guess is that it is the same for most) so it stills balances out
\r
68 > positively in the usability.
\r
70 I tested the patch and it works as advertised.
\r
72 I agree with Jani that y-or-n-p would suffice for clearing all
\r
73 recent searches (but yes-or-no-p is not so bad as I originally thought
\r
74 as C-g can be used to stop processing (typoing 'no' is too easy ;/).
\r
76 If we could use "undo" feature to restore last clear/del then I'd agree
\r
77 100% with Mark (i.e. no y-or-n-p for [del]).
\r
79 In any case fix at least the style issue Mark mentioned -- any of the
\r
80 yes/no queries will eventually be fine with me (as I don't know without
\r
81 experience what would be the best (for me) after all).
\r