1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CCC45431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 6 Aug 2012 07:29:01 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 4wl+LICsmT0I for <notmuch@notmuchmail.org>;
\r
16 Mon, 6 Aug 2012 07:29:01 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id DA0D5431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 6 Aug 2012 07:29:00 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id CE58B1002A4; Mon, 6 Aug 2012 17:29:10 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH] emacs: Make moving to the previous message move to the
\r
26 In-Reply-To: <1342237668-2489-1-git-send-email-amdragon@mit.edu>
\r
27 References: <1342237668-2489-1-git-send-email-amdragon@mit.edu>
\r
28 User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1
\r
29 (x86_64-redhat-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 06 Aug 2012 17:29:10 +0300
\r
34 Message-ID: <m2d334ksax.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain; charset=us-ascii
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 06 Aug 2012 14:29:01 -0000
\r
51 On Sat, Jul 14 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
53 > Previously, notmuch-show-previous-message would move to the beginning
\r
54 > of the message before the message containing point. This patch makes
\r
55 > it instead move to the previous message *boundary*. That is, if point
\r
56 > isn't already at the beginning of the message, it moves to the
\r
57 > beginning of the current message. This is consistent with
\r
58 > notmuch-show-next-message, which can be thought of as moving to the
\r
59 > next message boundary. Several people have expressed a preference for
\r
63 LGTM. Contrary to what I wrote in id:"m2pq746tlq.fsf@guru.guru-group.fi"
\r
64 I think this could be pushed...
\r
68 > This patch accompanies the series in [0] (though they're independent
\r
69 > and can be applied in either order). This makes the behavior of 'p'
\r
70 > and 'P' in show-mode conceptually similar to the new behavior of 'p'
\r
73 > [0] 1342140319-19859-1-git-send-email-amdragon@mit.edu
\r
75 > emacs/notmuch-show.el | 10 +++++++---
\r
76 > 1 file changed, 7 insertions(+), 3 deletions(-)
\r
78 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
79 > index 6335d45..02e319f 100644
\r
80 > --- a/emacs/notmuch-show.el
\r
81 > +++ b/emacs/notmuch-show.el
\r
82 > @@ -1525,9 +1525,11 @@ thread, navigate to the next thread in the parent search buffer."
\r
83 > (goto-char (point-max)))))
\r
85 > (defun notmuch-show-previous-message ()
\r
86 > - "Show the previous message."
\r
87 > + "Show the previous message or the start of the current message."
\r
89 > - (notmuch-show-goto-message-previous)
\r
90 > + (if (= (point) (notmuch-show-message-top))
\r
91 > + (notmuch-show-goto-message-previous)
\r
92 > + (notmuch-show-move-to-message-top))
\r
93 > (notmuch-show-mark-read)
\r
94 > (notmuch-show-message-adjust))
\r
96 > @@ -1587,7 +1589,9 @@ to show, nil otherwise."
\r
97 > (defun notmuch-show-previous-open-message ()
\r
98 > "Show the previous open message."
\r
100 > - (while (and (notmuch-show-goto-message-previous)
\r
101 > + (while (and (if (= (point) (notmuch-show-message-top))
\r
102 > + (notmuch-show-goto-message-previous)
\r
103 > + (notmuch-show-move-to-message-top))
\r
104 > (not (notmuch-show-message-visible-p))))
\r
105 > (notmuch-show-mark-read)
\r
106 > (notmuch-show-message-adjust))
\r
110 > _______________________________________________
\r
111 > notmuch mailing list
\r
112 > notmuch@notmuchmail.org
\r
113 > http://notmuchmail.org/mailman/listinfo/notmuch
\r