1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2D736431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 17 Mar 2012 08:50:28 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 27hqDDUAxzmx for <notmuch@notmuchmail.org>;
\r
16 Sat, 17 Mar 2012 08:50:27 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 5D68C431FAE
\r
20 for <notmuch@notmuchmail.org>; Sat, 17 Mar 2012 08:50:27 -0700 (PDT)
\r
21 X-AuditID: 1209190f-b7f8a6d000000914-d4-4f64b2c17ae4
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 3E.EA.02324.1C2B46F4; Sat, 17 Mar 2012 11:50:25 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2HFoPQj027685;
\r
27 Sat, 17 Mar 2012 11:50:25 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2HFoNCF004098
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Sat, 17 Mar 2012 11:50:24 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1S8vtf-0003x5-5D; Sat, 17 Mar 2012 11:50:23 -0400
\r
37 Date: Sat, 17 Mar 2012 11:50:23 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme.
\r
41 Message-ID: <20120317155023.GH2670@mit.edu>
\r
42 References: <1331836925-31437-1-git-send-email-markwalters1009@gmail.com>
\r
43 <1331836925-31437-4-git-send-email-markwalters1009@gmail.com>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <1331836925-31437-4-git-send-email-markwalters1009@gmail.com>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixG6nontwU4q/wcKdphar5/JYXL85k9mB
\r
51 yWPnrLvsHs9W3WIOYIrisklJzcksSy3St0vgymj63sRccIu74vyCG+wNjBs5uxg5OSQETCSu
\r
52 vXzCCmGLSVy4t56ti5GLQ0hgH6PEqqVnWCGcDYwSM08dZYRwTjJJbDnTCFW2hFFi0oTzTCD9
\r
53 LAKqEgefXgObxSagIbFt/3JGEFtEQEfi9qEF7CA2s4C0xLffzWD1wgJ+Em8+zgar4RXQlljz
\r
54 9gkTxNBORom3M1+xQiQEJU7OfMIC0awlcePfS6AiDrBBy/9xgIQ5BbwkVv/dBjZfVEBFYsrJ
\r
55 bWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbomermZJXqpKaWbGEGB
\r
56 zSnJv4Px20GlQ4wCHIxKPLwcE5L9hVgTy4orcw8xSnIwKYnytm5I8RfiS8pPqcxILM6ILyrN
\r
57 SS0+xCjBwawkwiu1HCjHm5JYWZValA+TkuZgURLnVdN65yckkJ5YkpqdmlqQWgSTleHgUJLg
\r
58 /b4RqFGwKDU9tSItM6cEIc3EwQkynAdo+FeQGt7igsTc4sx0iPwpRl2O7qmPLjEKseTl56VK
\r
59 ifMmAFOKkABIUUZpHtwcWEJ6xSgO9JYw7yWQUTzAZAY36RXQEiagJTPLkkGWlCQipKQaGCuF
\r
60 Ti5Kb9/P/9F0q/C15coPV0S4Lyot1bPfl28YJXzRJ+nFjflfefoFnPZfm7w5Q99gQblmcHqB
\r
61 7/zNU7letb2tYtnSwxr65Mn6fOlVJbwbtGRnOwsb7/xk+PTMzUWntLPytrfliG5uN1xo80fq
\r
62 fMbvOcFytaZ5DzawfDq7VY871l84uMdJXomlOCPRUIu5qDgRAOFWCAcjAwAA
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Sat, 17 Mar 2012 15:50:28 -0000
\r
78 Quoth Mark Walters on Mar 15 at 6:42 pm:
\r
79 > This commit replaces the --no-exclude option with a
\r
80 > --exclude=(true|false|flag) option. The default is to omit the
\r
81 > excluded messages.
\r
83 > The flag option only makes sense if output=summary (as otherwise there
\r
84 > is nowhere to print the flag). In summary output exclude=false and
\r
85 > exclude=flag give almost identical output:
\r
86 > they differ in that with the exclude=flag option the match count
\r
87 > (i.e., the x in [x/n] in the output) is the number of matching
\r
88 > non-excluded messages rather than the number of matching messages.
\r
90 > Note this changes the default for output=summary when no --exclude=
\r
91 > option is given: it used to default to flag and now defaults to true
\r
92 > (i.e. omit excluded messages). This is neccesary to keep the cli
\r
93 > output uncluttered and for speed reasons.
\r
96 Code looks good, but I think there need to be a few more tests. In
\r
97 particular, I think we need all 10 valid combinations of
\r
99 * --output=summary or --output=messages (those two are probably
\r
102 * The three types of exclude (or two for --output=messages)
\r
104 * Whether or not an excluded term is in the query
\r
106 Finally, the corpus should have three threads of interest: a thread
\r
107 with no excluded messages, a thread with both excluded and
\r
108 non-excluded messages, and a thread consisting entirely of excluded
\r
111 We already have many of these, but it would be good to systematically
\r
112 cover the full gamut of possibilities.
\r