1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A6FBB431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 03:33:53 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ke6D1T3TA8H4 for <notmuch@notmuchmail.org>;
\r
16 Sun, 9 Jun 2013 03:33:44 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id BD741431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 03:33:44 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 2DC0F100044;
\r
22 Sun, 9 Jun 2013 13:33:42 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2] emacs: show: change emacs interactive pipe message.
\r
26 In-Reply-To: <1370767308-1636-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1369944667-22705-1-git-send-email-markwalters1009@gmail.com>
\r
28 <1370767308-1636-1-git-send-email-markwalters1009@gmail.com>
\r
29 User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sun, 09 Jun 2013 13:33:41 +0300
\r
35 Message-ID: <m27gi3y3ne.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 09 Jun 2013 10:33:53 -0000
\r
52 On Sun, Jun 09 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
54 > Previously the query string for piping a message to a command was
\r
55 > "Pipe message to command: " regardless of whether the function was
\r
56 > called with a prefix argument (which pipes all open messages to the
\r
57 > command). This patch modifies the `interactive' command to reflect
\r
60 > This has the whitespace fix Tomi mentioned but is otherwise unchanged.
\r
62 LGTM, my review comments in id:m2wqqftvu3.fsf@guru.guru-group.fi apply.
\r
73 > emacs/notmuch-show.el | 5 ++++-
\r
74 > 1 files changed, 4 insertions(+), 1 deletions(-)
\r
76 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
77 > index 83bb9ad..d863f2b 100644
\r
78 > --- a/emacs/notmuch-show.el
\r
79 > +++ b/emacs/notmuch-show.el
\r
80 > @@ -1702,7 +1702,10 @@ to stdout or stderr will appear in the *notmuch-pipe* buffer.
\r
81 > When invoked with a prefix argument, the command will receive all
\r
82 > open messages in the current thread (formatted as an mbox) rather
\r
83 > than only the current message."
\r
84 > - (interactive "P\nsPipe message to command: ")
\r
85 > + (interactive (let ((query-string (if current-prefix-arg
\r
86 > + "Pipe all open messages to command: "
\r
87 > + "Pipe message to command: ")))
\r
88 > + (list current-prefix-arg (read-string query-string))))
\r
89 > (let (shell-command)
\r
91 > (setq shell-command
\r
95 > _______________________________________________
\r
96 > notmuch mailing list
\r
97 > notmuch@notmuchmail.org
\r
98 > http://notmuchmail.org/mailman/listinfo/notmuch
\r