1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0F333431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:47 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id e6NTR5+YeGWs for <notmuch@notmuchmail.org>;
\r
17 Thu, 18 Oct 2012 20:55:46 -0700 (PDT)
\r
18 Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com
\r
19 [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 6A261431FAE
\r
22 for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:46 -0700 (PDT)
\r
23 Received: by mail-vb0-f53.google.com with SMTP id fc21so40924vbb.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:45 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=h40uiBQEZojm1y1Y1lvmt3SBNoHLkbx/6MzR95f2XuY=;
\r
29 b=JFpWp5Yyro52w4bx4K1HAwdFv46i8tC2991tr7wMbFk89+6RS9estq+8blXvX/61hd
\r
30 rggCDLDZIpqQhQxkgDDSF/u83q7MjrwwWDXlp76igYxSL3+OQ0PvM7pS+QdTijsj6eFy
\r
31 n50zqD5bcc8aeLCpZz/pIUYIwHZ2Lk8t8NdC9vMfARGJEq3nZfNTsLj68yy6FWhhItEu
\r
32 pfAkC1zSUX8Ngqp37fLCsy0tmfThtUYLHbT7/tVDMqIvE3uQsVg+ZlpF0chHRxNCDwFG
\r
33 s8MdAa/P43xjGgW80VjE0gIdGLMF8pExdK014nHvpLOAXJNw0lmqgfsdI2QdDIAwkkl5
\r
35 Received: by 10.52.23.225 with SMTP id p1mr14645207vdf.79.1350618945742;
\r
36 Thu, 18 Oct 2012 20:55:45 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id zx18sm615107veb.3.2012.10.18.20.55.43
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Thu, 18 Oct 2012 20:55:43 -0700 (PDT)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Adrien Bustany <adrien@bustany.org>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected
\r
44 In-Reply-To: <1342636475-16057-4-git-send-email-adrien@bustany.org>
\r
45 References: <1342636475-16057-1-git-send-email-adrien@bustany.org>
\r
46 <1342636475-16057-4-git-send-email-adrien@bustany.org>
\r
47 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Thu, 18 Oct 2012 23:55:40 -0400
\r
50 Message-ID: <87wqyn6rpf.fsf@betacantrips.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 19 Oct 2012 03:55:47 -0000
\r
67 Adrien Bustany <adrien@bustany.org> writes:
\r
69 > This makes notmuch appropriately free the underlying notmuch C objects
\r
70 > when garbage collecting their Go wrappers. To make sure we don't break
\r
71 > the underlying links between objects (for example, a notmuch_messages_t
\r
72 > being GC'ed before a notmuch_message_t belonging to it), we add for each
\r
73 > wraper struct a pointer to the owner object (Go objects with a reference
\r
74 > pointing to them don't get garbage collected).
\r
76 Hi Adrien! This whole series is marked moreinfo, but I don't think
\r
77 that's just. It looks like there were some unresolved issues about
\r
78 reference tracking and garbage collection, and some suggestions to use
\r
79 the C values of enums instead of regenerating them with iota, but
\r
80 there's definitely valid code that I assume would be useful if anyone
\r
81 ever wanted to write in Go ;). Are you figuring to clean this series up?
\r
83 This comment should s/wraper/wrapper/.
\r