1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 64DB3429E25
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Sep 2011 03:19:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id jBEC-u6ERJX6 for <notmuch@notmuchmail.org>;
\r
17 Tue, 13 Sep 2011 03:19:34 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9D9E7431FB6
\r
22 for <notmuch@notmuchmail.org>; Tue, 13 Sep 2011 03:19:34 -0700 (PDT)
\r
23 Received: by bkbzt12 with SMTP id zt12so396993bkb.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 13 Sep 2011 03:19:33 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=yow821+2S1CLXCiKfbO3Xk7VY54JPiCcmexWm/1CzkQ=;
\r
29 b=lq8nx/M1kKjymV1vEHYFhmWAi0hL6ksR/BKS0yeI5A9+sv8uevWWj3AynZJy/l0Dtz
\r
30 SzZtWBaA+LvEF44J6KPZH0qFdP2jEnGoXImyQv6KycDrWHBur6P/lOL8VLY48SLDNvtq
\r
31 hF5cmONu3k2RuV4JD+vjSa81lj7YlpcyBTgX4=
\r
32 Received: by 10.204.7.151 with SMTP id d23mr1847238bkd.19.1315909170631;
\r
33 Tue, 13 Sep 2011 03:19:30 -0700 (PDT)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id t16sm925397bkv.11.2011.09.13.03.19.27
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 13 Sep 2011 03:19:28 -0700 (PDT)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: david@tethera.net, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH] test: reset test_subtest_known_broken_ after each
\r
42 In-Reply-To: <1315881714-23759-1-git-send-email-david@tethera.net>
\r
43 References: <87obyqvc4s.fsf@gmail.com>
\r
44 <1315881714-23759-1-git-send-email-david@tethera.net>
\r
45 User-Agent: Notmuch/0.8-19-g1ca96a5 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Tue, 13 Sep 2011 14:19:36 +0400
\r
48 Message-ID: <87vcswd9s7.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 Cc: David Bremner <bremner@debian.org>
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Tue, 13 Sep 2011 10:19:35 -0000
\r
66 On Mon, 12 Sep 2011 23:41:54 -0300, david@tethera.net wrote:
\r
67 > From: David Bremner <bremner@debian.org>
\r
69 > This means that test_subtest_known_broken needs to be called before
\r
70 > every known broken subtest, which is no different than what is
\r
71 > documented for the test_begin_subtest case.
\r
73 > The assumption is that every test ends up calling either skipping,
\r
74 > calling test_ok_ or test_failure_ and and the latter in turn delegate
\r
75 > to the known_broken versions in the case where
\r
76 > test_subtest_known_broken_ is set.
\r
84 > test/test-lib.sh | 3 +++
\r
85 > 1 files changed, 3 insertions(+), 0 deletions(-)
\r
87 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
88 > index 196ef49..966b2dc 100755
\r
89 > --- a/test/test-lib.sh
\r
90 > +++ b/test/test-lib.sh
\r
91 > @@ -574,12 +574,14 @@ test_failure_message_ () {
\r
94 > test_known_broken_ok_ () {
\r
95 > + test_subtest_known_broken_=
\r
96 > test_fixed=$(($test_fixed+1))
\r
97 > say_color pass "%-6s" "FIXED"
\r
101 > test_known_broken_failure_ () {
\r
102 > + test_subtest_known_broken_=
\r
103 > test_broken=$(($test_broken+1))
\r
104 > test_failure_message_ "BROKEN" "$@"
\r
106 > @@ -614,6 +616,7 @@ test_skip () {
\r
108 > case "$to_skip" in
\r
110 > + test_subtest_known_broken_=
\r
111 > say_color skip >&3 "skipping test: $@"
\r
112 > say_color skip "%-6s" "SKIP"
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r