1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0F259431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 05:04:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RiiYOGdKu-iX for <notmuch@notmuchmail.org>;
\r
16 Fri, 25 Nov 2011 05:04:46 -0800 (PST)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6529B431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 05:04:46 -0800 (PST)
\r
22 Received: from convex-new.cs.unb.ca ([131.202.13.154])
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pAPD4iLZ011146;
\r
24 Fri, 25 Nov 2011 09:04:44 -0400
\r
25 Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.72)
\r
26 (envelope-from <bremner@unb.ca>)
\r
27 id 1RTvSO-00031N-AT; Fri, 25 Nov 2011 09:04:44 -0400
\r
28 From: David Bremner <david@tethera.net>
\r
29 To: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>,
\r
30 notmuch@notmuchmail.org
\r
31 Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in
\r
33 In-Reply-To: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
\r
34 References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
\r
35 User-Agent: Notmuch/0.10~rc1+12~g53b921d (http://notmuchmail.org) Emacs/23.3.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Fri, 25 Nov 2011 09:04:44 -0400
\r
38 Message-ID: <878vn4bbf7.fsf@convex-new.cs.unb.ca>
\r
40 Content-Type: text/plain; charset=utf-8
\r
41 Content-Transfer-Encoding: quoted-printable
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Fri, 25 Nov 2011 13:04:47 -0000
\r
56 On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidecoe@a=
\r
59 > +$(dir)/symbol-test: $(dir)/symbol-test.o
\r
60 > + $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
\r
62 I'm a bit surprised no -I is neaded here. Is that taken care in the CC call?
\r
64 > .PHONY: test check
\r
65 > -test: all $(dir)/smtp-dummy
\r
66 > +test: all $(dir)/smtp-dummy $(dir)/symbol-test
\r
67 > @${dir}/notmuch-test $(OPTIONS)
\r
69 The instructions were already wrong, but maybe they should be updated to
\r
70 point out that calling the test scripts directly requires smtp-dummy and
\r
71 symbol-test already be built. Or maybe the tests should check for these
\r
72 binaries as pre-reqs along with emacs, gpg, etc...=20
\r
74 > + -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose|sy=
\r
75 mbol-test.cc|symbol-test|symbol-test.o)/d" \
\r
77 I wonder if this should be shortened (and made a bit sloppier) with the
\r