1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 1866D6DE17AA
\r
6 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 04:48:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.117 tagged_above=-999 required=5 tests=[AWL=0.117]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id NgB_06bLHupY for <notmuch@notmuchmail.org>;
\r
16 Sun, 30 Aug 2015 04:48:44 -0700 (PDT)
\r
17 Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id EFE3E6DE1642
\r
19 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 04:48:43 -0700 (PDT)
\r
20 Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1ZW14a-0007D2-Fk; Sun, 30 Aug 2015 11:46:56 +0000
\r
23 Received: (nullmailer pid 15097 invoked by uid 1000); Sun, 30 Aug 2015
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
27 Subject: Re: [RFC PATCH 4/5] cli: change the data structure for notmuch
\r
28 address deduplication
\r
29 In-Reply-To: <87h9nh1aol.fsf@nikula.org>
\r
30 References: <cover.1440859765.git.jani@nikula.org>
\r
31 <ffe5975fd070d3e8e22602b01ceb8bf0d7d47ae0.1440859765.git.jani@nikula.org>
\r
32 <87a8t9tuka.fsf@maritornes.cs.unb.ca> <87h9nh1aol.fsf@nikula.org>
\r
33 User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sun, 30 Aug 2015 08:46:35 -0300
\r
36 Message-ID: <877fodt2w4.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.18
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 30 Aug 2015 11:48:46 -0000
\r
53 Jani Nikula <jani@nikula.org> writes:
\r
55 >> I found this use of mailbox as a temporary variable confusing; despite
\r
56 >> the obvious return I thought it might have something to do with the
\r
57 >> g_list_append below. Maybe just make a block scope temporary variable?
\r
59 > This is how the function would turn out with that. Better, I guess? I
\r
60 > also tried to think of ways to combine the two g_list_append paths here,
\r
61 > but in the end doing it like this has most clarity I think.
\r
64 Your (new) version is fine for me. As it happens I was thinking of a
\r
68 l = g_list_find_custom (list, mailbox, mailbox_compare);
\r
72 talloc_free (mailbox);
\r