1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F0DAE431FDE
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 Mar 2015 09:48:20 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ASEK+0ywZvc9 for <notmuch@notmuchmail.org>;
\r
16 Wed, 25 Mar 2015 09:48:18 -0700 (PDT)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
19 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 6A0B5431E62
\r
22 for <notmuch@notmuchmail.org>; Wed, 25 Mar 2015 09:48:17 -0700 (PDT)
\r
23 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
24 4.80) (envelope-from <david@tethera.net>)
\r
25 id 1YaoSc-0005jp-CB; Wed, 25 Mar 2015 16:47:18 +0000
\r
26 Received: (nullmailer pid 18353 invoked by uid 1000); Wed, 25 Mar 2015
\r
28 From: David Bremner <david@tethera.net>
\r
29 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
30 Subject: Re: [Patch v5 4/8] lib: add "verbose" versions of
\r
31 notmuch_database_{open,create}
\r
32 In-Reply-To: <m2bnjhuj43.fsf@guru.guru-group.fi>
\r
33 References: <1426352554-4383-10-git-send-email-david@tethera.net>
\r
34 <1427203451-1540-1-git-send-email-david@tethera.net>
\r
35 <1427203451-1540-5-git-send-email-david@tethera.net>
\r
36 <m2bnjhuj43.fsf@guru.guru-group.fi>
\r
37 User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Wed, 25 Mar 2015 12:47:06 -0400
\r
40 Message-ID: <87a8z1owhh.fsf@maritornes.cs.unb.ca>
\r
42 Content-Type: text/plain
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Wed, 25 Mar 2015 16:48:21 -0000
\r
57 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
59 >> + ret = notmuch_database_open_verbose (path,
\r
60 >> + NOTMUCH_DATABASE_MODE_READ_WRITE,
\r
64 >> + if (status_cb) status_cb (message, closure);
\r
68 > Is this ever printing the message (if any?)
\r
70 Printing messages is the whole point of status_cb. It does switch the
\r
71 output from the current stderr to stdout, which is weird. On the other
\r
72 hand it avoids changing the api by adding
\r
73 notmuch_database_compact_verbose.
\r
75 And of course if we care this should free message after calling
\r
76 status_cb, like the other places.
\r