1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9C094431FBD
\r
6 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 07:21:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id y+RMKakFslMk for <notmuch@notmuchmail.org>;
\r
17 Tue, 24 Jan 2012 07:21:38 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D9B3F431FB6
\r
22 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 07:21:37 -0800 (PST)
\r
23 Received: by bkbzt19 with SMTP id zt19so2467544bkb.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 07:21:35 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=wPuUMFv+JldMiRUBkjROB7Tn5CQAd+GAEfqeh/bqno0=;
\r
29 b=m8kdoiUmTlmjRTKID5MLR5yxpEp+adHdoWAP7/mV5HhpUNsLapvSH8Q+3ryJpSGEFg
\r
30 UnP+nSq2izyZlyH2KNl+IKPcJs+3efE3LuCLCo+AprZwWCBbobrE6lOCAQBCgJxSKWmL
\r
31 pdTedfQ7lj+dDEgkqK/z8e4X0WNfWSk9SEcLo=
\r
32 Received: by 10.205.130.12 with SMTP id hk12mr5077889bkc.56.1327418495248;
\r
33 Tue, 24 Jan 2012 07:21:35 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id bw9sm15552906bkb.8.2012.01.24.07.21.33
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 24 Jan 2012 07:21:34 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 1/4 v42] test: Don't return the result of checking for
\r
41 running emacs to the tester.
\r
42 In-Reply-To: <1327341947-29206-1-git-send-email-dme@dme.org>
\r
43 References: <1326804748-8989-2-git-send-email-dme@dme.org>
\r
44 <1327341947-29206-1-git-send-email-dme@dme.org>
\r
45 User-Agent: Notmuch/0.11+100~gd650abf (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Tue, 24 Jan 2012 19:20:28 +0400
\r
48 Message-ID: <87hazlm8jn.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Tue, 24 Jan 2012 15:21:38 -0000
\r
65 On Mon, 23 Jan 2012 18:05:44 +0000, David Edmondson <dme@dme.org> wrote:
\r
66 > When checking for a running emacs, test_emacs evaluates the empty list
\r
67 > '()'. This returns 'nil' when emacs is running, which is then
\r
68 > prepended to the actual test result. Given that it is not part of the
\r
69 > actual test output the test harness can incorrectly report test
\r
70 > failure (or success).
\r
73 > Commentary updated.
\r
81 > test/test-lib.sh | 2 +-
\r
82 > 1 files changed, 1 insertions(+), 1 deletions(-)
\r
84 > diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
85 > index 0da60fb..82c686c 100644
\r
86 > --- a/test/test-lib.sh
\r
87 > +++ b/test/test-lib.sh
\r
88 > @@ -926,7 +926,7 @@ test_emacs () {
\r
89 > --eval '(orphan-watchdog $$)'" || return
\r
90 > EMACS_SERVER="$server_name"
\r
91 > # wait until the emacs server is up
\r
92 > - until test_emacs '()' 2>/dev/null; do
\r
93 > + until test_emacs '()' >/dev/null 2>/dev/null; do
\r
100 > _______________________________________________
\r
101 > notmuch mailing list
\r
102 > notmuch@notmuchmail.org
\r
103 > http://notmuchmail.org/mailman/listinfo/notmuch
\r