1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 071796DE17EB
\r
6 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=1.203 tagged_above=-999 required=5 tests=[AWL=-0.193,
\r
12 SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id z_I5zmznAd8Y for <notmuch@notmuchmail.org>;
\r
16 Sun, 30 Aug 2015 08:03:33 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 007406DE17E1
\r
19 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 08:03:32 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 0713E10005A;
\r
22 Sun, 30 Aug 2015 18:02:07 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 1/2] emacs: add defsubst
\r
26 notmuch-address--message-insinuated
\r
27 In-Reply-To: <87y4gtrmdr.fsf@maritornes.cs.unb.ca>
\r
28 References: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>
\r
29 <87y4gtrmdr.fsf@maritornes.cs.unb.ca>
\r
30 User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sun, 30 Aug 2015 18:02:06 +0300
\r
36 Message-ID: <m27foc251t.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.18
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 30 Aug 2015 15:03:35 -0000
\r
53 On Sun, Aug 30 2015, David Bremner <david@tethera.net> wrote:
\r
55 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
57 >> +(defsubst notmuch-address--message-insinuated ()
\r
58 >> + (memq notmuch-address-message-alist-member message-completion-alist))
\r
61 > Is there some advantage to defsubst other than (maybe?) performance? It
\r
62 > just seems like one more construct for people to get up to speed with
\r
65 No advantage. The reason for defsubst may originally be that I did it for
\r
66 least execution chance -- and iirc I was reading some (gnus?) code that
\r
67 had quite a few defsubsts which infected my coding. Now that I checked
\r
68 there is no (other) defsubsts code in notmuch-emacs... so that can be
\r
69 just be changed to `defun' to be consistent in that sense.
\r