1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C8585431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 6 Apr 2012 08:38:18 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id AxxN-3h5Rfj6 for <notmuch@notmuchmail.org>;
\r
18 Fri, 6 Apr 2012 08:38:16 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 270E3431FAE
\r
23 for <notmuch@notmuchmail.org>; Fri, 6 Apr 2012 08:38:15 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1SGBEo-0001sI-Pj; Fri, 06 Apr 2012 16:38:11 +0100
\r
28 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
30 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
31 (envelope-from <m.walters@qmul.ac.uk>)
\r
32 id 1SGBEo-0000iY-FH; Fri, 06 Apr 2012 16:38:10 +0100
\r
33 From: Mark Walters <markwalters1009@gmail.com>
\r
34 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
35 notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)
\r
37 In-Reply-To: <87bon47v0o.fsf@servo.finestructure.net>
\r
38 References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com>
\r
39 <87bon47v0o.fsf@servo.finestructure.net>
\r
40 User-Agent: Notmuch/0.12+96~g8f5ec3b (http://notmuchmail.org) Emacs/23.3.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Fri, 06 Apr 2012 16:38:20 +0100
\r
43 Message-ID: <87ty0w50r7.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 X-Sender-Host-Address: 94.192.233.223
\r
47 X-QM-SPAM-Info: Sender has good ham record. :)
\r
48 X-QM-Body-MD5: 1e624825d6275d7cbb637cd4d1746cd9 (of first 20000 bytes)
\r
49 X-SpamAssassin-Score: -1.2
\r
50 X-SpamAssassin-SpamBar: -
\r
51 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
53 spam. We require at least 5.0 points to mark a message as spam.
\r
54 This message scored -1.2 points.
\r
55 Summary of the scoring:
\r
56 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
58 * [138.37.6.40 listed in list.dnswl.org]
\r
59 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
60 provider * (markwalters1009[at]gmail.com)
\r
61 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
63 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
64 * 0.1 AWL AWL: From: address is in the auto white-list
\r
65 X-QM-Scan-Virus: ClamAV says the message is clean
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Fri, 06 Apr 2012 15:38:18 -0000
\r
80 On Fri, 06 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
81 > On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
82 >> This is the latest version of the patch series (previous version at [1]).
\r
83 >> I think this version fixes all the problems raised by Austin in his review.
\r
85 > Tested and reviewed and LGTM.
\r
87 > Unfortunately, though, I just now noticed that the tests don't cover
\r
88 > count and show excludes. Since everything else looks good, let's just
\r
89 > make a new version of [0]. I suggest we name the new test script just
\r
90 > "excludes" and then add count and show tests there. That should be
\r
91 > pretty straightforward.
\r
93 There are some exclude tests for count in test/count. Do you think it
\r
94 needs to be a full test everything like in test/search-exclude?
\r
96 There aren't any tests for show exclude, but there aren't very many
\r
97 tests explicitly for show anyway. My preference would be to add
\r
99 id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add
\r
100 some tests to that. I could add some tests for show-excludes in the same format
\r
101 as the search-exclude tests though if you think that is better.
\r
107 > Thanks again, Mark.
\r
111 > [0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com"
\r