1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1AE6E431FC0
\r
6 for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 09:00:01 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id bd+dIXfZZyKq for <notmuch@notmuchmail.org>;
\r
17 Tue, 7 Aug 2012 09:00:00 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 620D4431FAF
\r
22 for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 09:00:00 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SymCK-0003TN-Ht; Tue, 07 Aug 2012 16:59:59 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SymCK-000262-6e; Tue, 07 Aug 2012 16:59:56 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] reply: Convert JSON format to use sprinter
\r
35 In-Reply-To: <1344344230-9937-1-git-send-email-amdragon@mit.edu>
\r
36 References: <1344344230-9937-1-git-send-email-amdragon@mit.edu>
\r
37 User-Agent: Notmuch/0.13.2+96~g634443c (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Tue, 07 Aug 2012 16:59:49 +0100
\r
40 Message-ID: <87k3xabslm.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 94.192.233.223
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: efaa6eca1b9335628939c80835879687 (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: -1.8
\r
47 X-SpamAssassin-SpamBar: -
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored -1.8 points.
\r
52 Summary of the scoring:
\r
53 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
55 * [138.37.6.40 listed in list.dnswl.org]
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
60 * 0.5 AWL AWL: From: address is in the auto white-list
\r
61 X-QM-Scan-Virus: ClamAV says the message is clean
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Tue, 07 Aug 2012 16:00:01 -0000
\r
78 On Tue, 07 Aug 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
79 > Almost all of reply was already being formatted using the sprinter.
\r
80 > This patch converts the top-level dictionary to use the sprinter
\r
84 > One last sprinter piece that had slipped through the cracks.
\r
91 > notmuch-reply.c | 8 ++++----
\r
92 > 1 file changed, 4 insertions(+), 4 deletions(-)
\r
94 > diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
95 > index fa6665f..e60a264 100644
\r
96 > --- a/notmuch-reply.c
\r
97 > +++ b/notmuch-reply.c
\r
98 > @@ -614,20 +614,20 @@ notmuch_reply_format_json(void *ctx,
\r
101 > sp = sprinter_json_create (ctx, stdout);
\r
102 > + sp->begin_map (sp);
\r
104 > /* The headers of the reply message we've created */
\r
105 > - printf ("{\"reply-headers\": ");
\r
106 > + sp->map_key (sp, "reply-headers");
\r
107 > format_headers_json (sp, reply, TRUE);
\r
108 > g_object_unref (G_OBJECT (reply));
\r
111 > /* Start the original */
\r
112 > - printf (", \"original\": ");
\r
114 > + sp->map_key (sp, "original");
\r
115 > format_part_json (ctx, sp, node, TRUE, TRUE);
\r
118 > - printf ("}\n");
\r
120 > notmuch_message_destroy (message);
\r
126 > _______________________________________________
\r
127 > notmuch mailing list
\r
128 > notmuch@notmuchmail.org
\r
129 > http://notmuchmail.org/mailman/listinfo/notmuch
\r