1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id F34E06DE0231
\r
6 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 12:24:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.064 tagged_above=-999 required=5 tests=[AWL=0.003,
\r
12 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,
\r
13 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652,
\r
14 UNPARSEABLE_RELAY=0.001] autolearn=disabled
\r
15 Received: from arlo.cworth.org ([127.0.0.1])
\r
16 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id uwXFuUlQF3jz for <notmuch@notmuchmail.org>;
\r
18 Tue, 9 Feb 2016 12:24:43 -0800 (PST)
\r
19 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com
\r
20 [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 6D8CE6DE01D3 for
\r
21 <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 12:24:43 -0800 (PST)
\r
22 Received: by mail-wm0-f65.google.com with SMTP id p63so25219wmp.1
\r
23 for <notmuch@notmuchmail.org>; Tue, 09 Feb 2016 12:24:43 -0800 (PST)
\r
24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=dme-org.20150623.gappssmtp.com; s=20150623;
\r
26 h=to:subject:in-reply-to:references:from:date:message-id:mime-version
\r
27 :content-type; bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=;
\r
28 b=nytkSuSHjOCMbmAtSYMIKPp5z9EDagvgKtx0uFoxUB1Of6tv8pu2mhITYZcNiAcnoC
\r
29 IAJ4xyZVu+7hVgfgmt1lb0pOz0rOUPwdGdNHcWJSd/HWg5P8LDd3BQl4OFdRsO/VghTJ
\r
30 wLMyEJnp1xhMu4XDgLaIFq/4stjO0381QPQDf/xiZ95cesx0r/QIPNbzwTbGG0Uq5UOn
\r
31 Wr7PmvBQl+LzhmNaYocgFxwF7ZoysBsoeLisV3Z0rwplYogVylJxChRi3rBNm5++xoOk
\r
32 cEU43YCJLeh2NtCsaQTAcGEyRB7BoNQur0xQewJkNpbBqLE3sPP9Sq874R7KnmhUPwYg
\r
34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
35 d=1e100.net; s=20130820;
\r
36 h=x-gm-message-state:to:subject:in-reply-to:references:from:date
\r
37 :message-id:mime-version:content-type;
\r
38 bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=;
\r
39 b=OCrbzOFTfiAnJ+9OgQFMCG976sHsKf6wsh4XTu8qspHIROheBr73wlBWjDw0WiUHVR
\r
40 Xs7n/CBypYu4pkw1ubyP0pnMPSQAcar5gSDI59myEpjMP42A1SXFER/D21PHZ8LV2vbZ
\r
41 hvn7nyDoh6FHjF9lD3IJa/XWJxW9cl1tU5iUfBPTPfrOjxYJJLiex/zHWXn6/I5wFGyq
\r
42 z9NQvwo84z44vC6FPxg7NorEXcl7HdiQIMwmu2/+bs8bHQOqM/ySv8CyfiNfAGjDoV0c
\r
43 KgyjoyyQzEKaPD5SGqGcC4dh59GlqQJs4Zr43J74+PkDzpgOiWtUtyhuSrCrMRMAfhRn
\r
46 AG10YOSPkQqgszglraxjOfM9r2/+X0oSpKk+Zhl5sjTq7oipHUZEsnEihyEMHH533hh+Qw==
\r
47 X-Received: by 10.28.180.84 with SMTP id d81mr7324807wmf.42.1455049481469;
\r
48 Tue, 09 Feb 2016 12:24:41 -0800 (PST)
\r
49 Received: from disaster-area.hh.sledj.net
\r
50 ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])
\r
51 by smtp.gmail.com with ESMTPSA id b1sm36305127wjy.0.2016.02.09.12.24.39
\r
52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
53 Tue, 09 Feb 2016 12:24:39 -0800 (PST)
\r
54 Received: from localhost (disaster-area.hh.sledj.net [local])
\r
55 by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id e4f5946b;
\r
56 Tue, 9 Feb 2016 20:24:38 +0000 (UTC)
\r
57 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
58 Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'
\r
59 In-Reply-To: <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>
\r
60 References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>
\r
61 <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>
\r
62 From: David Edmondson <dme@dme.org>
\r
63 Date: Tue, 09 Feb 2016 20:24:38 +0000
\r
64 Message-ID: <m2io1x4oop.fsf@dme.org>
\r
66 Content-Type: text/plain
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.20
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Tue, 09 Feb 2016 20:24:46 -0000
\r
81 On Sat, Jun 13 2015, Mark Walters wrote:
\r
82 > Change the key binding for filter (or "limit") in search-mode. This
\r
83 > gives consistency with the new filter in show-mode, and frees 'f' for
\r
84 > forward-thread in the future.
\r
86 Is there a conclusion on this change? The patch itself seems obviously
\r
87 fine from a code perspective, at issue is more whether it's acceptable
\r
88 to change the key binding.
\r
90 The equivalent binding in notmuch-show mode is already "l", and I think
\r
91 that it makes sense to be consistent (i.e. the change should be
\r
95 > emacs/notmuch.el | 4 ++--
\r
96 > 1 file changed, 2 insertions(+), 2 deletions(-)
\r
98 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
99 > index 6564816..06e3b94 100644
\r
100 > --- a/emacs/notmuch.el
\r
101 > +++ b/emacs/notmuch.el
\r
102 > @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map
\r
103 > (define-key map "o" 'notmuch-search-toggle-order)
\r
104 > (define-key map "c" 'notmuch-search-stash-map)
\r
105 > (define-key map "t" 'notmuch-search-filter-by-tag)
\r
106 > - (define-key map "f" 'notmuch-search-filter)
\r
107 > + (define-key map "l" 'notmuch-search-filter)
\r
108 > (define-key map [mouse-1] 'notmuch-search-show-thread)
\r
109 > (define-key map "*" 'notmuch-search-tag-all)
\r
110 > (define-key map "a" 'notmuch-search-archive-thread)
\r
111 > @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()
\r
112 > (notmuch-search-refresh-view))
\r
114 > (defun notmuch-search-filter (query)
\r
115 > - "Filter the current search results based on an additional query string.
\r
116 > + "Filter or LIMIT the current search results based on an additional query string.
\r
118 > Runs a new search matching only messages that match both the
\r
119 > current search results AND the additional query string provided."
\r