1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2F803431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 04:38:26 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ICwDI9SiYwte for <notmuch@notmuchmail.org>;
\r
16 Fri, 31 Aug 2012 04:38:25 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 5B1C4431FAE
\r
19 for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 04:38:25 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 226F710014D; Fri, 31 Aug 2012 14:38:32 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, david@tethera.net
\r
24 Subject: Re: [PATCH] test: use (format "%S") to print nil in emacs test.
\r
25 In-Reply-To: <m23933lcod.fsf@guru.guru-group.fi>
\r
26 References: <1346375399-449-1-git-send-email-david@tethera.net>
\r
27 <20120831035227.GH11179@mit.edu>
\r
28 <m23933lcod.fsf@guru.guru-group.fi>
\r
29 User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/23.1.1
\r
30 (x86_64-redhat-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Fri, 31 Aug 2012 14:38:32 +0300
\r
35 Message-ID: <m23933jnpj.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Fri, 31 Aug 2012 11:38:26 -0000
\r
53 On Fri, Aug 31 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
55 > On Fri, Aug 31 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
57 >> LGTM. Alternatively, the test could be
\r
58 >> (null (notmuch-wash....))
\r
59 >> with the correct answer being 't'. That would avoid the awkward
\r
60 >> detour through a string, but either way is good as long as this test
\r
63 > I was going to vote this (null ... thing) but as the function returns
\r
64 > nil when no match found it is more obvious th compare for that instead
\r
67 > And, there is not much of a detour for the expected value nil, outputted
\r
68 > as "nil" (without quotes) :).
\r
72 > LGTM. "Alternatively, the test could" use (prin1 (...)) directly,
\r
73 > "but either way is good as long as this test passes."
\r
75 I withdraw this prin1 suggestion, as it doesn't seem to work with
\r
76 all emaces (if any, I thought I test this well enough).
\r
77 Probably the reason is that format returns string and prin1 prints
\r
78 it -- but when using emacsclient the prints (might) go to the buffer
\r
81 So, unconditional LGTM :D
\r
90 >> Quoth david@tethera.net on Aug 30 at 10:09 pm:
\r
91 >>> From: David Bremner <bremner@debian.org>
\r
93 >>> The behaviour of "emacsclient --eval nil" changed from emacs23 to
\r
94 >>> emacs24, and in emacs24 it prints 'nil' rather than an empty string.
\r
96 >>> (format "%S" foo) produces a sexpr form of foo, and is consistent
\r
97 >>> between the two versions.
\r
100 >>> This fixes another test failure on emacs24.
\r
102 >>> I guess maybe all test_emacs output could be canonicalized this way,
\r
103 >>> but I suspect that would be pretty disruptive.
\r
105 >>> test/emacs-subject-to-filename | 6 +++---
\r
106 >>> 1 file changed, 3 insertions(+), 3 deletions(-)
\r
108 >>> diff --git a/test/emacs-subject-to-filename b/test/emacs-subject-to-filename
\r
109 >>> index 176e685..a0ffdfe 100755
\r
110 >>> --- a/test/emacs-subject-to-filename
\r
111 >>> +++ b/test/emacs-subject-to-filename
\r
112 >>> @@ -8,10 +8,10 @@ test_emacs '(ignore)'
\r
114 >>> # test notmuch-wash-subject-to-patch-sequence-number (subject)
\r
115 >>> test_begin_subtest "no patch sequence number"
\r
116 >>> -output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number
\r
117 >>> - "[PATCH] A normal patch subject without numbers")'
\r
118 >>> +output=$(test_emacs '(format "%S" (notmuch-wash-subject-to-patch-sequence-number
\r
119 >>> + "[PATCH] A normal patch subject without numbers"))'
\r
121 >>> -test_expect_equal "$output" ""
\r
122 >>> +test_expect_equal "$output" '"nil"'
\r
124 >>> test_begin_subtest "patch sequence number #1"
\r
125 >>> output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number
\r
126 >> _______________________________________________
\r
127 >> notmuch mailing list
\r
128 >> notmuch@notmuchmail.org
\r
129 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r