1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id AE6566DE163F
\r
6 for <notmuch@notmuchmail.org>; Mon, 7 Sep 2015 06:55:25 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=1.164 tagged_above=-999 required=5 tests=[AWL=-0.232,
\r
12 SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 0UvrBMhZIrz1 for <notmuch@notmuchmail.org>;
\r
16 Mon, 7 Sep 2015 06:55:23 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 664636DE147C
\r
19 for <notmuch@notmuchmail.org>; Mon, 7 Sep 2015 06:55:22 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 4ED4F100033;
\r
22 Mon, 7 Sep 2015 16:55:20 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes
\r
26 In-Reply-To: <1441632818-22483-2-git-send-email-david@tethera.net>
\r
27 References: <1441632818-22483-1-git-send-email-david@tethera.net>
\r
28 <1441632818-22483-2-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Mon, 07 Sep 2015 16:55:20 +0300
\r
35 Message-ID: <m2bndegwqf.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.18
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 07 Sep 2015 13:55:25 -0000
\r
52 On Mon, Sep 07 2015, David Bremner <david@tethera.net> wrote:
\r
55 > notmuch-count.c | 6 +++---
\r
56 > 1 file changed, 3 insertions(+), 3 deletions(-)
\r
58 > diff --git a/notmuch-count.c b/notmuch-count.c
\r
59 > index 66f5e53..a844384 100644
\r
60 > --- a/notmuch-count.c
\r
61 > +++ b/notmuch-count.c
\r
62 > @@ -117,7 +117,7 @@ count_file (notmuch_database_t *notmuch, FILE *input, const char **exclude_tags,
\r
66 > - while (!ret && (line_len = getline (&line, &line_size, input)) != -1) {
\r
67 > + while (! ret && (line_len = getline (&line, &line_size, input)) != -1) {
\r
68 > chomp_newline (line);
\r
69 > ret = print_count (notmuch, line, exclude_tags, exclude_tags_length,
\r
70 > output, print_lastmod);
\r
71 > @@ -189,7 +189,7 @@ notmuch_count_command (notmuch_config_t *config, int argc, char *argv[])
\r
73 > notmuch_exit_if_unmatched_db_uuid (notmuch);
\r
75 > - query_str = query_string_from_args (config, argc-opt_index, argv+opt_index);
\r
76 > + query_str = query_string_from_args (config, argc - opt_index, argv + opt_index);
\r
77 > if (query_str == NULL) {
\r
78 > fprintf (stderr, "Out of memory.\n");
\r
79 > return EXIT_FAILURE;
\r
80 > @@ -197,7 +197,7 @@ notmuch_count_command (notmuch_config_t *config, int argc, char *argv[])
\r
82 > if (exclude == EXCLUDE_TRUE) {
\r
83 > search_exclude_tags = notmuch_config_get_search_exclude_tags
\r
84 > - (config, &search_exclude_tags_length);
\r
85 > + (config, &search_exclude_tags_length);
\r
87 With the first 2 uncrustify does a good job, but this last one it disagrees
\r
88 how emacs(1) indents (and how it is currently indented in other notmuch
\r
89 source files) -- I'd leave the last (3rd) change out.
\r
91 Note that in this file uncrustify had a chance to do pretty good job -- in
\r
92 some other files there are many more changes that need to be post-edited...
\r