1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 23993429E25
\r
6 for <notmuch@notmuchmail.org>; Thu, 23 Jun 2011 15:58:31 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id vmqq7dAKaLQD for <notmuch@notmuchmail.org>;
\r
17 Thu, 23 Jun 2011 15:58:30 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 4DBAD431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 23 Jun 2011 15:58:30 -0700 (PDT)
\r
23 Received: by bwg12 with SMTP id 12so2085504bwg.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 23 Jun 2011 15:58:28 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:from:to:cc:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=/WW3MSutRlT9I1Cp9jaVBejF6jcirFtGF+dD1cDExa0=;
\r
29 b=qT+iJDkrOiwvjM2bbTexR7uHsJ0U5ejXO0fr3kOGrczSZvbzLy50yImdWg9tSDJzYO
\r
30 yA/pQGH9/M0nwXDLooDecZP3A0piTNbzYmrLKRSIsCuuOtFqdCLty0woN9UH/dLMcr77
\r
31 x9Gb7lk4KRJgoh1WZc+mp/TspSw+/Azbl5bNs=
\r
32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
33 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
34 :message-id:mime-version:content-type;
\r
35 b=QLwjx2TZVoAIqH3UOdu+JuTS8Cd43fGBI7ss5QsymWBNK/9x2HGoSaD8atKFxl62+F
\r
36 nL5usuH9F1L8w9b/yA4aEeTLXH3adsjczBOKH//ZZ5uhOh8XhiHoXTDQzNPmh2JdvUV8
\r
37 bGPOTFGtNAbmp5rZXjn5RNoxTrBLTSpH3iB8U=
\r
38 Received: by 10.204.6.210 with SMTP id a18mr1327744bka.180.1308869908700;
\r
39 Thu, 23 Jun 2011 15:58:28 -0700 (PDT)
\r
40 Received: from localhost ([91.144.186.21])
\r
41 by mx.google.com with ESMTPS id g13sm1124264bkd.10.2011.06.23.15.58.26
\r
42 (version=TLSv1/SSLv3 cipher=OTHER);
\r
43 Thu, 23 Jun 2011 15:58:27 -0700 (PDT)
\r
44 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
\r
46 Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.
\r
47 In-Reply-To: <87hb7gdw7d.fsf@yoom.home.cworth.org>
\r
48 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
\r
49 <1306619520-25730-2-git-send-email-jrollins@finestructure.net>
\r
50 <1306619520-25730-3-git-send-email-jrollins@finestructure.net>
\r
51 <1306619520-25730-4-git-send-email-jrollins@finestructure.net>
\r
52 <1306619520-25730-5-git-send-email-jrollins@finestructure.net>
\r
53 <1306619520-25730-6-git-send-email-jrollins@finestructure.net>
\r
54 <1306619520-25730-7-git-send-email-jrollins@finestructure.net>
\r
55 <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
\r
56 <1306619520-25730-9-git-send-email-jrollins@finestructure.net>
\r
57 <1306619520-25730-10-git-send-email-jrollins@finestructure.net>
\r
58 <1306619520-25730-11-git-send-email-jrollins@finestructure.net>
\r
59 <1306619520-25730-12-git-send-email-jrollins@finestructure.net>
\r
60 <1306619520-25730-13-git-send-email-jrollins@finestructure.net>
\r
61 <1306619520-25730-14-git-send-email-jrollins@finestructure.net>
\r
62 <1306619520-25730-15-git-send-email-jrollins@finestructure.net>
\r
63 <874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>
\r
64 <87oc2ellzn.fsf@yoom.home.cworth.org> <87ipsmpswj.fsf@gmail.com>
\r
65 <87hb7gdw7d.fsf@yoom.home.cworth.org>
\r
66 User-Agent: Notmuch/0.5-260-g027d4ad (http://notmuchmail.org) Emacs/23.3.1
\r
67 (x86_64-pc-linux-gnu)
\r
68 Date: Fri, 24 Jun 2011 02:58:23 +0400
\r
69 Message-ID: <87hb7g17g0.fsf@gmail.com>
\r
71 Content-Type: text/plain; charset=us-ascii
\r
72 Cc: David Bremner <bremner@debian.org>
\r
73 X-BeenThere: notmuch@notmuchmail.org
\r
74 X-Mailman-Version: 2.1.13
\r
76 List-Id: "Use and development of the notmuch mail system."
\r
77 <notmuch.notmuchmail.org>
\r
78 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
79 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
80 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
81 List-Post: <mailto:notmuch@notmuchmail.org>
\r
82 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
83 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
84 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
85 X-List-Received-Date: Thu, 23 Jun 2011 22:58:31 -0000
\r
87 On Thu, 23 Jun 2011 15:22:46 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
88 > On Sat, 04 Jun 2011 00:22:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
89 > > On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
90 > > > > I do not think we need a test for this fix. What we need are tests for
\r
91 > > > > FCC functionality when notmuch-fcc-dirs is a list.
\r
95 > I've written these now. And they do test this fix. What they show is
\r
96 > that a legitimate setting (of notmuch-fcc-dirs as a list) was resulting
\r
97 > in an error rather than working. That's a nasty little bug, (and poor
\r
98 > coverage from our test suite before.
\r
100 > > Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when
\r
101 > > `notmuch-fcc-dirs' is set to a list. The error was in the
\r
102 > > `notmuch-fcc-dirs' format check which was changed in an incompatible
\r
103 > > way from 0.4 to 0.5.
\r
105 > Thanks for the fixed wording. I've now pushed out the fix (along with
\r
108 > With all the talk of "old style" vs. "new style" I was thinking that the
\r
109 > bug only affected people with the old-style FCC setting. The bug is much
\r
110 > worse than that, (preventing people from using the new list-based
\r
113 > Anyway, thanks for the patch, Dmitry. And thanks for pushing me to take
\r
117 Well, I should have prepared a better commit message from the
\r
118 beginning. Then no pushing might have been needed :)
\r
123 > David, I suggest including this fix (and its test) in the release
\r
129 > carl.d.worth@intel.com
\r