9f/7a71107e675cbdc13df6417ff59c4d8463a5ec

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 11631431FBF\r
   6         for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 14:36:12 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id bBAIleMNM1cZ for <notmuch@notmuchmail.org>;\r
  16         Tue, 28 Jan 2014 14:36:03 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu\r
  18         [18.9.25.14])\r
  19         (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 94DC4431FBD\r
  22         for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 14:36:03 -0800 (PST)\r
  23 X-AuditID: 1209190e-f79ee6d000000c40-5f-52e830d20609\r
  24 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  25         (using TLS with cipher AES256-SHA (256/256 bits))\r
  26         (Client did not present a certificate)\r
  27         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  28         id 9E.E7.03136.2D038E25; Tue, 28 Jan 2014 17:36:02 -0500 (EST)\r
  29 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  30         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id s0SMa0xp007923; \r
  31         Tue, 28 Jan 2014 17:36:01 -0500\r
  32 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  33         (authenticated bits=0)\r
  34         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  35         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s0SMZwc9014540\r
  36         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  37         Tue, 28 Jan 2014 17:36:00 -0500\r
  38 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  39         (envelope-from <amdragon@mit.edu>)\r
  40         id 1W8HG5-0001YW-74; Tue, 28 Jan 2014 17:35:57 -0500\r
  41 From: Austin Clements <amdragon@MIT.EDU>\r
  42 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  43 Subject: Re: [PATCH 1/1] emacs: ad-activate 'mm-shr after ad-disable-advice\r
  44         'mm-shr\r
  45 In-Reply-To: <1390854732-7501-1-git-send-email-tomi.ollila@iki.fi>\r
  46 References: <1390854732-7501-1-git-send-email-tomi.ollila@iki.fi>\r
  47 User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1\r
  48         (i486-pc-linux-gnu)\r
  49 Date: Tue, 28 Jan 2014 17:35:51 -0500\r
  50 Message-ID: <87ob2vn394.fsf@awakening.csail.mit.edu>\r
  51 MIME-Version: 1.0\r
  52 Content-Type: text/plain; charset=us-ascii\r
  53 X-Brightmail-Tracker:\r
  54  H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixG6nrnvJ4EWQQf9NbYvrN2cyW7xZOY/V\r
  55         gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4MrYv/Qye8E/zoqr15YxNzB2cXQxcnJICJhI\r
  56         nJp9kRHCFpO4cG89WxcjF4eQwGwmiZWNW6GcjYwSez+dZ4RwTjNJzP7eyQLhLGGUaFp9igWk\r
  57         n01AQ2Lb/uVgs0QEbCWuLDnJ2sXIwcEMNLd9XghIWFggWKLpzlywEk4BJ4m223fZQUqEBBwl\r
  58         Tr+QAAmLCiRJnJ76mxXEZhFQldh0/zlYOS/Qpcc7tjJB2IISJ2c+AdvKLKAlcePfS6YJjIKz\r
  59         kKRmIUktYGRaxSibklulm5uYmVOcmqxbnJyYl5dapGusl5tZopeaUrqJERSonJJ8Oxi/HlQ6\r
  60         xCjAwajEwxtw/nmQEGtiWXFl7iFGSQ4mJVHe5XIvgoT4kvJTKjMSizPii0pzUosPMUpwMCuJ\r
  61         8E6XBMrxpiRWVqUW5cOkpDlYlMR5b3LYBwkJpCeWpGanphakFsFkZTg4lCR4r+oDNQoWpaan\r
  62         VqRl5pQgpJk4OEGG8wANfwlSw1tckJhbnJkOkT/FqCglzmsGkhAASWSU5sH1whLJK0ZxoFeE\r
  63         ebeCVPEAkxBc9yugwUxAg1fuewIyuCQRISXVwKjQPWXt2XvHSqMXXfy6I2rOrcBJjQVPNYzq\r
  64         mRPqdscsXHbdLKtLtWb+xZajfcvrJqx7vq3CP7bYJtRi9j+WzSoKYYKlW2Xy/9x3PMAbURE/\r
  65         3UdzneQxY+3oWh8L7gpVxeL5B/lW6zIapq5Z16w2ZcNFkYq47/O/+rZkBhnJfjL78Kd5Y4/O\r
  66         BSWW4oxEQy3mouJEALKeWM//AgAA\r
  67 Cc: tomi.ollila@iki.fi\r
  68 X-BeenThere: notmuch@notmuchmail.org\r
  69 X-Mailman-Version: 2.1.13\r
  70 Precedence: list\r
  71 List-Id: "Use and development of the notmuch mail system."\r
  72         <notmuch.notmuchmail.org>\r
  73 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  75 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  76 List-Post: <mailto:notmuch@notmuchmail.org>\r
  77 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  78 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  79         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  80 X-List-Received-Date: Tue, 28 Jan 2014 22:36:12 -0000\r
  81 \r
  82 On Mon, 27 Jan 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
  83 > Imitated from "Enabling advice" in Emacs lisp manual...\r
  84 >\r
  85 > ad-disable-advice by itself only changes the enable flag for a\r
  86 > piece of advice. To make the change take effect in the\r
  87 > advised definition, the advice needs to be activated again.\r
  88 \r
  89 Oops, looks like this was my fault.\r
  90 \r
  91 This fix LGTM.\r
  92 \r
  93 > ---\r
  94 >  emacs/notmuch-lib.el | 3 ++-\r
  95 >  1 file changed, 2 insertions(+), 1 deletion(-)\r
  96 >\r
  97 > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
  98 > index e6e9f97..fa35fa9 100644\r
  99 > --- a/emacs/notmuch-lib.el\r
 100 > +++ b/emacs/notmuch-lib.el\r
 101 > @@ -531,7 +531,8 @@ the given type."\r
 102 >  (if (>= emacs-major-version 24)\r
 103 >      (defadvice mm-shr (before load-gnus-arts activate)\r
 104 >        (require 'gnus-art nil t)\r
 105 > -      (ad-disable-advice 'mm-shr 'before 'load-gnus-arts)))\r
 106 > +      (ad-disable-advice 'mm-shr 'before 'load-gnus-arts)\r
 107 > +      (ad-activate 'mm-shr)))\r
 108 >  \r
 109 >  (defun notmuch-mm-display-part-inline (msg part nth content-type process-crypto)\r
 110 >    "Use the mm-decode/mm-view functions to display a part in the\r
 111 > -- \r
 112 > 1.8.0\r
 113 >\r
 114 > _______________________________________________\r
 115 > notmuch mailing list\r
 116 > notmuch@notmuchmail.org\r
 117 > http://notmuchmail.org/mailman/listinfo/notmuch\r